Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patching Dank Mono as a Nerd Font is not sufficient to render this theme correctly. #8

Open
krotondo opened this issue Mar 9, 2019 · 2 comments

Comments

@krotondo
Copy link

krotondo commented Mar 9, 2019

I installed bash-it, bought Dank Mono and patched it using Nerd Fonts. However, after changing the Basic theme in Terminal to use this font, some characters are rendering as question marks:

 Always stay gracious, best revenge is your paper
┌ kate   Kates-MacBook-Pro   ~
└

The character before the ~ is rendering properly as a file folder, but the crown, person, computer, and >> all render as [?]. When I switch the font to the unpatched version, the file folder also doesn't render.

I tried switching to a patched font that ships with Nerd Fonts (Hack Nerd Font), and the characters all appear properly.

I set the font back to Dank Mono Nerd Font and restarted Terminal, but the problem persisted with Dank Mono Nerd Font.

I had patched the fonts using the following command, on both the ttf and otf versions, both regular and italic, before installing them in Font Book.

./font-patcher ~/Downloads/DankMono-491/ttf/DankMono-Regular.ttf

Are there additional required arguments or steps to patch the font?

@mloberg
Copy link

mloberg commented Jun 7, 2019

Nerd Fonts doesn't add glyphs automatically, you either need to specify which glyphs to add or use the --complete option to use them all. I would also recommend the -s option to make the glyphs mono.

@Zethtren
Copy link

@mloberg "-s" If I found this comment 2 hours sooner I would have samed so much headache...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants