-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: When constructing duplicate data using query expressions, the returned data may be incomplete. #33137
Comments
/assign @congqixia |
@lentitude2tk |
/assign @MrPresent-Han |
OK, I will upgrade to the latest version 2.4 and run the test. |
@xiaofan-luan I have upgraded to version 2.4.2-20240514-f48a7ff-72fc31b and conducted tests, which met expectations. From the results, it appears that Milvus 2.4 has optimized its query strategy compared to 2.3. For the same dataset with offset=0, limit=900, and expr="", querying the data (0-999) repeated 5 times:
|
/assign |
already fixed by #32567 , in this pr, the reduce of query will try the best to get the limit results (availableCount < limit).
|
Can this handling strategy code be synchronized to version 2.3? |
OK, I'll do it. @lentitude2tk |
issue: #33137 Signed-off-by: longjiquan <[email protected]>
issue: #33137 pr: #33178 Signed-off-by: longjiquan <[email protected]>
issue: #33137 pr: #32567 Co-authored-by: sunby <[email protected]> Co-authored-by: MrPresent-Han <[email protected]> --------- Signed-off-by: longjiquan <[email protected]>
…cated keys(milvus-io#33137) Signed-off-by: MrPresent-Han <[email protected]>
adding has_more_result_tag for various level's reduce to rectify reduce_stop_for_best Signed-off-by: MrPresent-Han <[email protected]>
adding has_more_result_tag for various level's reduce to rectify reduce_stop_for_best Signed-off-by: MrPresent-Han <[email protected]>
adding has_more_result_tag for various level's reduce to rectify reduce_stop_for_best Signed-off-by: MrPresent-Han <[email protected]>
adding has_more_result_tag for various level's reduce to rectify reduce_stop_for_best Signed-off-by: MrPresent-Han <[email protected]>
adding has_more_result_tag for various level's reduce to rectify reduce_stop_for_best Signed-off-by: MrPresent-Han <[email protected]>
adding has_more_result_tag for various level's reduce to rectify reduce_stop_for_best Signed-off-by: MrPresent-Han <[email protected]>
related: #33137 adding has_more_result_tag for various level's reduce to rectify reduce_stop_for_best Signed-off-by: MrPresent-Han <[email protected]>
adding has_more_result_tag for various level's reduce to rectify reduce_stop_for_best Signed-off-by: MrPresent-Han <[email protected]>
related: #33137 pr: #33422 Signed-off-by: MrPresent-Han <[email protected]>
related: milvus-io#33137 adding has_more_result_tag for various level's reduce to rectify reduce_stop_for_best Signed-off-by: MrPresent-Han <[email protected]>
pr: milvus-io#33422 issue: milvus-io#33137 Signed-off-by: MrPresent-Han <[email protected]>
…us-io#33422) related: milvus-io#33137 pr: milvus-io#33422 Signed-off-by: MrPresent-Han <[email protected]>
Is there an existing issue for this?
Environment
Current Behavior
When querying the data using a query expression with offset=0 and limit=900, I found that some data is missing in the returned results. For example, data points 351-354 are missing.
By querying through the interface or using queryIterator for a full query, it can be confirmed that data points 351-354 do actually exist.
Expected Behavior
First, it is expected that the returned data is de-duplicated, and there is no issue with that. However, the returned data should follow the correct sequence, and there should not be any data missing.
Steps To Reproduce
Milvus Log
No response
Anything else?
No response
The text was updated successfully, but these errors were encountered: