Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [2.4]datacoord/node watch based on rpc #32558

Merged
merged 1 commit into from May 8, 2024

Conversation

yiwangdr
Copy link
Contributor

issue: #25309

Copy link
Contributor

mergify bot commented Apr 24, 2024

@yiwangdr Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added the kind/feature Issues related to feature request from users label Apr 24, 2024
@yiwangdr yiwangdr changed the title feat: datacoord/node watch based on rpc feat: [2.4]datacoord/node watch based on rpc Apr 24, 2024
Copy link
Contributor

mergify bot commented Apr 24, 2024

@yiwangdr E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 82.39437% with 200 lines in your changes are missing coverage. Please review.

Project coverage is 81.43%. Comparing base (15b7874) to head (d80de78).
Report is 16 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #32558      +/-   ##
==========================================
- Coverage   81.75%   81.43%   -0.32%     
==========================================
  Files         998     1000       +2     
  Lines      125516   125258     -258     
==========================================
- Hits       102615   102005     -610     
- Misses      19037    19334     +297     
- Partials     3864     3919      +55     
Files Coverage Δ
internal/datacoord/channel_manager_factory.go 100.00% <100.00%> (ø)
internal/datacoord/session.go 84.61% <ø> (ø)
internal/datanode/data_node.go 82.20% <100.00%> (+0.78%) ⬆️
internal/datanode/event_manager.go 80.16% <100.00%> (-4.55%) ⬇️
internal/distributed/datanode/service.go 82.92% <100.00%> (ø)
pkg/util/conc/pool.go 88.13% <100.00%> (-0.20%) ⬇️
pkg/util/paramtable/component_param.go 98.44% <100.00%> (+<0.01%) ⬆️
tests/integration/minicluster_v2.go 72.72% <100.00%> (+0.20%) ⬆️
internal/datacoord/services.go 85.76% <50.00%> (+0.02%) ⬆️
internal/distributed/datacoord/service.go 88.83% <50.00%> (ø)
... and 10 more

... and 153 files with indirect coverage changes

@yiwangdr
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Apr 24, 2024
@yiwangdr yiwangdr requested review from xiaofan-luan and XuanYang-cn and removed request for cydrain April 24, 2024 16:30
@yiwangdr yiwangdr marked this pull request as draft April 25, 2024 01:53
@sre-ci-robot sre-ci-robot added the do-not-merge/work-in-progress Don't merge even CI passed. label Apr 25, 2024
@sre-ci-robot sre-ci-robot deleted the branch milvus-io:2.4 April 30, 2024 07:04
@xiaofan-luan
Copy link
Contributor

keep it open

@xiaofan-luan xiaofan-luan reopened this May 5, 2024
@sre-ci-robot sre-ci-robot added area/dependency Pull requests that update a dependency file area/internal-api labels May 5, 2024
@xiaofan-luan
Copy link
Contributor

@yiwangdr
please help on rebasing it and merge

@yiwangdr
Copy link
Contributor Author

yiwangdr commented May 5, 2024

@yiwangdr please help on rebasing it and merge

Sure. Is 2.4 branch still alive though?
Could you help to merge master #32036?

@yiwangdr yiwangdr marked this pull request as ready for review May 5, 2024 04:59
@sre-ci-robot sre-ci-robot removed the do-not-merge/work-in-progress Don't merge even CI passed. label May 5, 2024
@mergify mergify bot removed the ci-passed label May 5, 2024
Copy link
Contributor

mergify bot commented May 5, 2024

@yiwangdr ut workflow job failed, comment rerun ut can trigger the job again.

@yiwangdr
Copy link
Contributor Author

yiwangdr commented May 5, 2024

rerun ut

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: yiwangdr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot removed the ci-passed label May 8, 2024
@yiwangdr
Copy link
Contributor Author

yiwangdr commented May 8, 2024

/run-cpu-e2e

@mergify mergify bot added the ci-passed label May 8, 2024
@sre-ci-robot sre-ci-robot merged commit 68771fa into milvus-io:2.4 May 8, 2024
15 checks passed
@yiwangdr yiwangdr deleted the yiwang/rpc24 branch May 8, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation area/dependency Pull requests that update a dependency file area/internal-api area/test ci-passed dco-passed DCO check passed. do-not-merge/missing-related-pr kind/feature Issues related to feature request from users lgtm sig/testing size/XXL Denotes a PR that changes 1000+ lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants