Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Support datetime type #27577

Open
1 task done
xiaofan-luan opened this issue Oct 9, 2023 · 6 comments
Open
1 task done

[Feature]: Support datetime type #27577

xiaofan-luan opened this issue Oct 9, 2023 · 6 comments
Assignees
Labels
good first issue Good for newcomers hacktoberfest Issues picked by hacktoberfest kind/feature Issues related to feature request from users

Comments

@xiaofan-luan
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe.

Timestamp is a very common datatype in all databases.
We can convert timestamp into int64, but this will be a overhead for the user.

We can follow the definition of PG https://www.postgresql.org/docs/current/datatype-datetime.html about what datetime data type should behave

Describe the solution you'd like.

No response

Describe an alternate solution.

No response

Anything else? (Additional Context)

No response

@xiaofan-luan xiaofan-luan added the kind/feature Issues related to feature request from users label Oct 9, 2023
@xiaofan-luan xiaofan-luan added good first issue Good for newcomers hacktoberfest Issues picked by hacktoberfest labels Oct 9, 2023
@fool1280
Copy link

Hi, I'm interested in tackling this issue. May I ask where should I start?

@xiaofan-luan
Copy link
Contributor Author

Hi @fool1280

  1. start from adding a type from milvus.proto https://github.com/milvus-io/milvus-proto, there is a FieldSchema fields which you can
  2. implement create collection path, make sure we can create a collection with timestamp field
  3. implement the insert path, this usually starts from proxy function Insert(ctx context.Context, in *InsertRequest, opts ...grpc.CallOption) (*MutationResult, error)
  4. Implement the query/search path. make sure we can run where condition on datetime field

@fool1280
Copy link

Thank you. I want to ask for the DateTime, would it be possible for me to use the Timestamp type in https://protobuf.dev/reference/protobuf/google.protobuf/#timestamp, as converting into int64 would introduce overhead for the user?

@xiaofan-luan
Copy link
Contributor Author

Thank you. I want to ask for the DateTime, would it be possible for me to use the Timestamp type in https://protobuf.dev/reference/protobuf/google.protobuf/#timestamp, as converting into int64 would introduce overhead for the user?

This is not too hard. you just need to convert date time to timestamp and there is no blocker

@dugar-tarun
Copy link

Hello @xiaofan-luan, I'm interested to take this up. Can you please assign this to me?

@xiaofan-luan
Copy link
Contributor Author

/assign @dugar-tarun
please let me know if you need any help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest Issues picked by hacktoberfest kind/feature Issues related to feature request from users
Projects
None yet
Development

No branches or pull requests

3 participants