Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsafe deserialization in com.alibaba:fastjson #878

Open
king1302217 opened this issue Apr 25, 2024 · 7 comments
Open

Unsafe deserialization in com.alibaba:fastjson #878

king1302217 opened this issue Apr 25, 2024 · 7 comments

Comments

@king1302217
Copy link

milvus-sdk-java rely on fastjson. This jar is unsafe to use. Can we upgrate fastjson to other jar, such as jackson or gson?

@yhmo
Copy link
Contributor

yhmo commented Apr 25, 2024

ok, we will try replace it in the next minor version.

@yhmo
Copy link
Contributor

yhmo commented Apr 29, 2024

@king1302217
This article mentioned "To fully remediate CVE-2022-25845, we recommend upgrading Fastjson to the latest version, which is currently 1.2.83."

The java sdk is using this version:

<version.fastjson>1.2.83</version.fastjson>

So, can we say it is safe now?

@king1302217
Copy link
Author

@yhmo Fastjson is forbidden to use in my company. As far as I know, this jar is forbidden in many companies. So it is better to fix it in the next version

@TWSFar
Copy link

TWSFar commented May 6, 2024

@yhmo Our company also prohibits the use of Fastjson, and we have the same requirement. Can you optimize and upgrade it

@yhmo
Copy link
Contributor

yhmo commented May 6, 2024

Currently, the com.alibaba.fastjson.JSONObject is used as input of InsertParam/UpsertParam/InsertRowsParam and output of SearchResultsWrapper/QueryResultsWrapper. If we replace it with gson.JsonObject, will cause lots of impact on users' client code.

@king1302217
Copy link
Author

Yes, but i think it is very necessary to fix because many companies prohibit the use of Fastjson. So hope we can upgrade in next version. @yhmo

@yhmo
Copy link
Contributor

yhmo commented May 11, 2024

Note:
The work of replacing FastJson with Gson is not ready. Today we released two new minor versions v2.3.7/v2.4.1 to fix some blocking issues.
Replacing FastJson with Gson is postponed to the next minor version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants