-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
additional regressor for prophet does not work #63
Comments
Oof. That's a pretty egregious mistake on my part. I will have that fixed very soon, in the next release. |
Thanks @mikekeith52, waiting for the next release. :) |
Can I get you to review pull request #64? I confirmed that the code works but want to get your eyes on it to make sure there are no additional problems than what I was able to change. |
You should be able to upgrade to 0.18.11: |
Can we close this issue? |
The problem why additional regressor for prophet does not work due to these lines.
the
regr
object overrides the previousmodel
with additional regressors.https://github.com/mikekeith52/scalecast/blob/1a8301784fcd60b07bb963896c83ca1ccdf244cd/src/scalecast/Forecaster.py#L561C1-L566C31
The text was updated successfully, but these errors were encountered: