symbolWithContextSync causing Maximum call stack size exceeded

[jlchmura]

Mike,

The call to getAllSymbolsSync on line 303 was causing a RangeError in one of my symbol tables. Shouldn't it have localOnly set to true? Unless I misunderstand this use of this function, if we're looking for a symbol tied to a specific context, why would that symbol be in a non-local table anyway?

antlr4-c3/src/SymbolTable.ts

Line 303 in c0530ed

let symbols = this.getAllSymbolsSync(BaseSymbol);

[mike-lischke]

Yes, using only local symbols sounds reasonable. Did it solve your problem with that flag?

But even if it does, with deeply nested symbols this can always crash. Better would be to implement that as iteration (and exchange the duplicated local method code by a single implementation).

[jlchmura]

Using local only did solve the problem. Though you're correct, I do need to look into an iteration-based implementation because I do have deeply nested symbols and this is bound to pop up somewhere else.