Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Be able to change the segments suffix name from " -segXXX" to anything else. #2000

Closed
4 tasks done
masterofobzene opened this issue May 16, 2024 · 6 comments
Closed
4 tasks done

Comments

@masterofobzene
Copy link

masterofobzene commented May 16, 2024

The fewer issues I have to read, the more new features I will have time to implement, so I ask that you please try these things first

Description

The automatic " -seg001" suffix on files are triggering bugs in playlists that take "-" character as a special character. We need a way to input a custom suffix when this causes trouble OR you need to remove the "-" character from the automatic suffix.

The bug can be experienced on certain situations of many files in a m3u playlist using MPV.

Since I consider that adding a custom suffix would be handy even for other needs, I ask to add this feature in a future version.

@masterofobzene masterofobzene changed the title [FEATURE][BUG-CAUSING] Be able to change the segments suffix name from " -segXXX" to anything else. [FEATURE][PROBLEM-CAUSE] Be able to change the segments suffix name from " -segXXX" to anything else. May 16, 2024
@mifi
Copy link
Owner

mifi commented May 16, 2024

is this a problem in the newest version of losslesscut only? can you provide exact steps to reproduce the problem?

@masterofobzene
Copy link
Author

masterofobzene commented May 16, 2024

Its not a "problem" with losslesscut; its a problem with the renaming of files; apparently MPV player doesn't like the " -" character with a space before it since apparently it likes to read it as an argument (or that is what people on their github are saying).

I would like losslesscut to have an option to use custom suffixes instead of the automatic " -seg01" only, so I can set a different one that doesn't have conflicts with mpv.

To sum it up, its not losslesscut fault, but mpv's fault. I just think that custom suffixes would be a good fix and also a new option some people might find useful.

Maybe my title wasn't the best, I get it.

To make it more complex, I don't know for sure where this "bug" happens in mpv, sometimes (many, many times) it just works, sometimes with specific files (specific naming) it shows this behaviour where mpv can't load the apparently "oddly" named files having " -" in them. I've opened an issue on their github, to check if the program had any limits on playlist's size (because my playlists are huge) and got a ton of digital burocracy over me and violent contributors because I skipped their paperwork just to ask one question.

Long story short: mpv has the problem, but I think losslesscut may benefit from a new option that would solve my problem with mpv; and we all lived happy forever.

If you still need the steps, they are as follows:

1- make a rudimentary playlist (can use mkpl -github-) or use dir /B >playlist.m3u would also work. This playlist should contain at least 27000 files. Have many videos cutted using losslesscut (files ending with -segxxx.mp4)

2- make mpv play the huge playlist, and if planets align (because I don't know what exactly causes this yet, only " -" was the common denominator); MPV will fail to start.

3- renaming the files that have " -segxxx" on them to something else without "-" makes the playlist work.

Forget about the "causing problems" part of the title (that I already edited) its not a problem of losslesscut, instead think of this as a "feature request" only.

@masterofobzene masterofobzene changed the title [FEATURE][PROBLEM-CAUSE] Be able to change the segments suffix name from " -segXXX" to anything else. [FEATURE] Be able to change the segments suffix name from " -segXXX" to anything else. May 16, 2024
@mifi
Copy link
Owner

mifi commented May 18, 2024

hmm, so is the problem the leading space character in -segXX or is the problem the dash - ? I cannot reproduce the leading space problem. when i try to export it gives me input-seg01.mp4 (when I use ${FILENAME}-${SEG_SUFFIX}${EXT}).

what does your output file name template look like in the export confirm dialog?

if you want to remove the -segXX and provide your own suffix, then simply change the template to something like:

${FILENAME}_mysuffix${SEG_NUM}${EXT}

that will give you input_mysuffix01.mp4

@masterofobzene
Copy link
Author

Oh sorry... can I do that already? where? I must have missed it

PS: also not even sure what causes the problem, because its random (happens with some files while others works) BUT renaming the files in the folder that has the "problematic files" by removing the " -seg001" makes them work.

@mifi
Copy link
Owner

mifi commented May 19, 2024

in the Export options dialog click on the output file names:

Screenshot 2024-05-19 at 23 33 28

@masterofobzene
Copy link
Author

Ouch. I disabled that screen and never realized there was that option.
I suppose we can close this issue.

Sorry for bothering. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants