Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incrementally replace any types with strong types #2888

Open
1 of 5 tasks
Tracked by #2785
thewahome opened this issue Nov 10, 2023 · 4 comments
Open
1 of 5 tasks
Tracked by #2785

Incrementally replace any types with strong types #2888

thewahome opened this issue Nov 10, 2023 · 4 comments
Assignees

Comments

@thewahome
Copy link
Collaborator

thewahome commented Nov 10, 2023

Update the following locations

@ElinorW
Copy link
Collaborator

ElinorW commented Mar 26, 2024

This is continuous work that we can each contribute on

@musale
Copy link
Contributor

musale commented May 30, 2024

I think an approach we can use here is to tackle parts of the code that have fewer side effects. Looking at it from the project structure, parts in like modules can be handled first and slowly move to tightly coupled parts. Another way is looking at product features, for example, ensure the login/logout is strongly types first. All in all, at some point we will have a _huge_ish PR but with running the test and simple local checks, this can be done.

@musale
Copy link
Contributor

musale commented May 30, 2024

Current any counts in src folder, excluding files with no any can be viewed with this command in linux:

 grep -c -R 'any'| grep -v :0 | grep -v '.json' | grep -v '.png'

with output like:

app/middleware/localStorageMiddleware.ts:1
app/middleware/telemetryMiddleware.ts:3
app/services/actions/adaptive-cards-action-creator.ts:2
app/services/actions/permissions-action-creator.spec.ts:2
...

the total count we have is 137. Now we can reduce as we go.

@ElinorW
Copy link
Collaborator

ElinorW commented May 31, 2024

Great suggestion @musale.
We can create task lists under this issue to track the work as we go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants