winget upgrade offers older versions of already installed packages with non-standard versioning schemes

[brkerez]

Brief description of your issue

For some packages winget upgrade offers older versions of packages.

In this case, it is offering

• for CrystalDiskMark it is offering 8.0.4 which is older than the already installed 8.0.4a
• for Stardock.Fences it is offering 4.07.02 which is older than the already installed 4.1.0.6

I'm not sure how CrystalDiskMark was upgraded to 8.0.4a (probably manually by CrystalDiskMark installer by me), Fences was upgraded to 4.1.0.6 by its own built-in upgrade mechanism

• For Fences there is no 4.1.0.6 available yet in https://github.com/microsoft/winget-pkgs yet so the only problem is that it thinks 4.07.02 is newer than 4.1.0.6 already installed
• for CrystalDiskMark though there is already a newer 8.0.4c available in https://github.com/microsoft/winget-pkgs/blob/master/manifests/c/CrystalDewWorld/CrystalDiskMark/8.0.4c/CrystalDewWorld.CrystalDiskMark.yaml so I think winget upgrade should be offering 8.0.4c instead of 8.0.4 besides the fact it thinks 8.0.4 is newer than 8.0.4a

I know that those applications have non-standard versioning schemes (a suffix for CrystalDiskMark and 0 prefix in the minor version number for Fences) and I don't know if this is really a bug and if that should be handled in the package manifests somehow but I'm reporting it just in case there is some space for winget version matching improvement (not sure whether this relates to Matching logic needs to be updated #2995
)

Steps to reproduce

run winget upgrade | grep -E "CrystalDiskMark|Fences" with the latest versions of CrystalDiskMark / Fences installed

Expected behavior

winget upgrade shouldn't be offering older versions of already installed packages

Actual behavior

winget upgrade is offering older versions of already installed packages with non-standard versioning schemes

Environment

@pavel λ winget --info
Windows Package Manager (Preview) v1.5.441-preview
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.22621.1413
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.20.441.0

Logs: %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir

User Settings: %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\settings.json

Links
---------------------------------------------------------------------------
Privacy Statement   https://aka.ms/winget-privacy
License Agreement   https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage            https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale

Admin Setting                             State
--------------------------------------------------
LocalManifestFiles                        Disabled
BypassCertificatePinningForMicrosoftStore Disabled
InstallerHashOverride                     Disabled
LocalArchiveMalwareScanOverride           Disabled

[stephengillie]

Related:

• Improve version parsing to better support "preambles" #2394