Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maximizing the current editor while in zen mode causes current editor group size toggle state to be lost #212034

Open
axefrog opened this issue May 4, 2024 · 0 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member grid-widget Grid view widget workbench-zen Full screen 'Zen' view issues
Milestone

Comments

@axefrog
Copy link

axefrog commented May 4, 2024

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.89.0
  • OS Version: Windows 10

When maximizing an editor group, normally the sizes of each editor group are restored properly when toggling maximize off. In zen mode however, toggling maximize off causes the layout to enter a state where the current editor is expanded fully and all other editor groups are collapsed to their minimum sizes. The command "Toggle Editor Group Sizes" needs to then be executed twice to restore the original layout that was active before one of the editor groups was maximized. This is a confusing experience because it initially feels like all of the custom sizes chosen earlier have been lost, and only toggling the group sizes twice (and it isn't even obvious that toggling these sizes is even a feature) reveals that sizes haven't been lost, but rather just the toggle state of the current editor group sizes.

This only happens when toggling maximize off while still in zen mode. Maximizing while in zen mode, then exiting zen mode before unmaximizing, yields correct behaviour. So the problem appears to be specific to unmaximizing while still in zen mode.

Steps to Reproduce:

  1. Create a layout with multiple columns and rows. Drag dividers to set a custom size for each pane.
  2. Enter zen mode.
  3. Toggle maximize ON for one of the current editors.
  4. Toggle maximize OFF. All editor groups other than the current one have been toggled to a collapsed state.
@axefrog axefrog changed the title Maximizing the current editor while in zen mode causes editor group sizes to be lost Maximizing the current editor while in zen mode causes current editor group size toggle state to be lost May 4, 2024
@ulugbekna ulugbekna assigned benibenj and unassigned ulugbekna May 6, 2024
@benibenj benibenj added bug Issue identified by VS Code Team member as probable bug workbench-zen Full screen 'Zen' view issues grid-widget Grid view widget labels May 15, 2024
@benibenj benibenj added this to the Backlog milestone May 15, 2024
@benibenj benibenj added the confirmed Issue has been confirmed by VS Code Team member label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member grid-widget Grid view widget workbench-zen Full screen 'Zen' view issues
Projects
None yet
Development

No branches or pull requests

4 participants