Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boolean True/False independent highlight not supported for Python and JSON #180663

Closed
eavelardev opened this issue Apr 24, 2023 · 1 comment
Closed
Assignees
Labels
grammar Syntax highlighting grammar upstream-issue-linked This is an upstream issue that has been reported upstream

Comments

@eavelardev
Copy link

eavelardev commented Apr 24, 2023

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.77.3
  • OS Version: Ubuntu 22.04

Steps to Reproduce:

  1. Set constant.language.boolean.false and constant.language.boolean.true in your theme or json settings,
    Example:
{
    "scope": "constant.language.boolean.false",
    "settings": {
        "foreground": "#ff0054", // Red
    }
},
{
    "scope": "constant.language.boolean.true",
    "settings": {
        "foreground": "#41D046", // Green
    }
}
  1. Check highlight for true/false in .py and .js files
    boolean

To support this it seems constant.language.boolean.<true/false>.py patterns need to be defined in MagicPython.tmLanguage.json like in the js case. .json files also don't have this feature.

@eavelardev eavelardev changed the title Boolean True/False highlight not supported for Python Boolean True/False independent highlight not supported for Python and JSON Apr 24, 2023
@aeschli aeschli assigned alexr00 and unassigned aeschli Apr 25, 2023
@alexr00
Copy link
Member

alexr00 commented Apr 25, 2023

Both of those language just define constant.language for true and false. Opened feature requests on the upstream repos: MagicStack/MagicPython#258 and microsoft/vscode-JSON.tmLanguage#3

@alexr00 alexr00 closed this as completed Apr 25, 2023
@alexr00 alexr00 added grammar Syntax highlighting grammar upstream-issue-linked This is an upstream issue that has been reported upstream labels Apr 25, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
grammar Syntax highlighting grammar upstream-issue-linked This is an upstream issue that has been reported upstream
Projects
None yet
Development

No branches or pull requests

3 participants