-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Remote-SSH Bug]: reconnection logic is flaky after host sleep #9602
Comments
Thanks for the issue -- you checked that you tried out both versions of |
Looks like I was toggling the wrong setting, repro case is:
|
Ah, okay, so this is independent of the exec server. That makes sense off what I was seeing in the logs. |
in my case , when the network is broken, after the network recover, the forward port is not work。i can not visit the forwarded address in my location |
Is there an existing issue for this bug?
Required Troubleshooting Steps
remote.SSH.useLocalServer
settingRepro case only when:
Connect Locally
It connects successfully
->
VS Code reconnects, but warns that it failed to forward a port (I think the error message is stale after the reconnect succeeded though)
![image](https://private-user-images.githubusercontent.com/1273267/308261388-a27fcd70-7e9c-48b0-a427-21d98036ba06.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk1NDI3NjUsIm5iZiI6MTcxOTU0MjQ2NSwicGF0aCI6Ii8xMjczMjY3LzMwODI2MTM4OC1hMjdmY2Q3MC03ZTljLTQ4YjAtYTQyNy0yMWQ5ODAzNmJhMDYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDYyOCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA2MjhUMDI0MTA1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MWQ4NTIxMmEzOTRkM2U0NGZlNjI3ZjM4Y2M3NDBiNTM1OTcwOTc2NzY3ODNjOWY3ODFlNTNlOTY3MjEwNDQyMSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.rf_Jd_IXzF8TOhGLrTLmVTOTt15pIBCFtwtO8UcsOso)
Expected Behavior
VS Code reconnects without errors
Steps To Reproduce
useExecServer enabled, after laptop sleep (on Mac OS 14.3.1), when VS Code tries to reconnect it hits some initial connection trouble, and throws an error message, but seems to have reconnected fine.
Remote-SSH Log
Remote-SSH Log
Anything else?
I'm still digging around to see if any of the network monitoring tooling is interacting with anything here, but this was at least somewhat reproducible with useExecServer -> true, but not with it false.
The text was updated successfully, but these errors were encountered: