I'm adding some additional logging with #5870. If you could try the pre-release version of the extension tomorrow and set the log level to debug (command Developer: Set Log Level -> GitHub Pull Request -> Debug), then you'll get the new logging.

Once you have the new logging, can you try to reproduce the issue then check the GitHub Pull Request output for a log like that says "Merging PR"? That line will also include the email address. Can you confirm whether that email address is correct?

I had this same issue, so I captured a log with the pre-release version. I did not see anything in the log that says "Merging PR". Below is from selecting the correct email address, then pressing Squash and Merge. The -1 cost and undefined are interesting. It may be stopping on error before your new debug line.

2024-04-03 15:45:44.442 [debug] RateLimit> Extension rate limit remaining: 140, /user/emails
2024-04-03 15:45:44.756 [debug] GitHubRepository> Fetch authenticated user emails - done
2024-04-03 15:45:44.757 [debug] RateLimit> REST Rate limit remaining: 4994, cost: -1, /user/emails
2024-04-03 15:45:50.798 [debug] PullRequestOverviewPanel> initialized with PR
2024-04-03 15:45:54.906 [debug] RateLimit> Extension rate limit remaining: 140, undefined

I'm getting this same error Unable to merge pull request. GraphQL error: Invalid email address

2024-04-03 18:35:13.970 [debug] RateLimit> Extension rate limit remaining: 140, undefined
2024-04-03 18:37:25.065 [info] FolderRepositoryManager+3> Found GitHub repo for pr #33: yes
2024-04-03 18:37:25.065 [debug] GitHubRepository> Fetch pull request 33 - enter
2024-04-03 18:37:25.066 [debug] RateLimit> Extension rate limit remaining: 140, PullRequest
2024-04-03 18:37:25.547 [debug] RateLimit> GraphQL Rate limit remaining: 4819, cost: 1, PullRequest
2024-04-03 18:37:25.547 [debug] GitHubRepository> Fetch pull request 33 - done
2024-04-03 18:37:25.548 [info] FolderRepositoryManager+3> Found GitHub pr repo for pr #33: yes
2024-04-03 18:37:25.548 [info] GitHubRepository> Fetch branch main - enter
2024-04-03 18:37:25.548 [debug] RateLimit> Extension rate limit remaining: 140, GetBranch
2024-04-03 18:37:25.780 [debug] RateLimit> GraphQL Rate limit remaining: 4818, cost: 1, GetBranch
2024-04-03 18:37:25.781 [info] GitHubRepository> Fetch branch main - done: true
2024-04-03 18:37:25.784 [debug] PullRequestModel> Fetch file changes, base, head and merge base of PR #33 - enter
2024-04-03 18:37:25.785 [debug] IssueModel> Fetch viewers latest review commit
2024-04-03 18:37:25.786 [debug] RateLimit> Extension rate limit remaining: 140, LatestReviewCommit
2024-04-03 18:37:26.059 [debug] RateLimit> GraphQL Rate limit remaining: 4817, cost: 1, LatestReviewCommit
2024-04-03 18:37:26.060 [debug] RateLimit> Extension rate limit remaining: 140, /repos/{owner}/{repo}/compare/{base}...{head}
2024-04-03 18:37:26.298 [debug] RateLimit> REST Rate limit remaining: 4965, cost: -1, /repos/{owner}/{repo}/compare/{base}...{head}
2024-04-03 18:37:26.298 [debug] PullRequestModel> Fetch file changes and merge base of PR #33 - done, total files 4
2024-04-03 18:37:26.360 [debug] RateLimit> Extension rate limit remaining: 140, PullRequestFiles
2024-04-03 18:37:26.361 [debug] RateLimit> Extension rate limit remaining: 139, PullRequestComments
2024-04-03 18:37:26.629 [debug] RateLimit> GraphQL Rate limit remaining: 4816, cost: 1, PullRequestFiles
2024-04-03 18:37:26.645 [debug] RateLimit> GraphQL Rate limit remaining: 4796, cost: 20, PullRequestComments
2024-04-03 18:37:26.647 [debug] RateLimit> Extension rate limit remaining: 140, GetPendingReviewId
2024-04-03 18:37:26.870 [debug] RateLimit> GraphQL Rate limit remaining: 4795, cost: 1, GetPendingReviewId

GitHub Pull Requests v0.82.1

Version: 1.87.2 (system setup)
Commit: 863d2581ecda6849923a2118d93a088b0745d9d6
Date: 2024-03-08T15:20:17.278Z
Electron: 27.3.2
ElectronBuildId: 26836302
Chromium: 118.0.5993.159
Node.js: 18.17.1
V8: 11.8.172.18-electron.0
OS: Windows_NT x64 10.0.20348

I also tried on v0.83.2024030509 (pre-release) and the result is exactly the same.

Thanks for the logs, but they are missing the new log line. The latest pre-release version of the extension requires that you use VS Code insiders (at least it will for a few more hours, there should be a new stable version of VS Code and the extension today).

I did switch to the insiders plugin. I think the error happens earlier on.

Just to add more to this discussion, I am able to merge the PR if I use the Create Merge Commit button from the GitHub Pull Request sub-menu, but (like the others have said) it doesn't work if I try to do the same thing from the Pull Request description screen

Hey @alexr00,

I updated my VSCode and I'm on the latest pre-release of GitHub Pull Requests.

GitHub Pull Requests: v0.87.2024040414 (pre-release)

Version: 1.88.0 (system setup)
Commit: 5c3e652f63e798a5ac2f31ffd0d863669328dc4c
Date: 2024-04-03T13:26:18.741Z
Electron: 28.2.8
ElectronBuildId: 27744544
Chromium: 120.0.6099.291
Node.js: 18.18.2
V8: 12.0.267.19-electron.0
OS: Windows_NT x64 10.0.20348

The issue still exists.

Unable to merge pull request. GraphQL error: Invalid email address

2024-04-04 13:57:16.560 [debug] FolderRepositoryManager+0> Merging PR: 33 method: merge for user: "[email protected]" - enter

2024-04-04 13:57:16.561 [debug] RateLimit> Extension rate limit remaining: 140, undefined

Thanks!

@ericohlin thanks for sharing those log! Is the email address listed in the logs the one that you expected the merge to be associated with? No extra spaces or other incorrect characters?

@ericohlin thanks for sharing those log! Is the email address listed in the logs the one that you expected the merge to be associated with? No extra spaces or other incorrect characters?

Hey @alexr00, thank you for the quick response. Yes, that's correct. I sanitized the log before sharing. To double-check, I copied the value from the log into Beyond Compare and then manually typed my email address, and they appear to be a 100% match. Everything looks exactly as it should.

Ok, I'm not sure what's going on here then. Does your email address have any special characters? If you go to github.com to merge the PR are you allowed to select this email address there?

Ok, I'm not sure what's going on here then. Does your email address have any special characters? If you go to github.com to merge the PR are you allowed to select this email address there?

Good morning. There are no special characters in my email address. If I go to github.com and merge the PR, when I click on Merge Pull Request, it says just above the Commit Merge button This commit will be authored by [email protected] and the email address is identical to the one in the logs.

This may be helpful, or maybe it's not, but this PR also has a commit from another team member. There are two total commits, one from me and one from my teammate.

If I go to github.com and merge the PR, when I click on Merge Pull Request, it says just above the Commit Merge button This commit will be authored by [email protected] and the email address is identical to the one in the logs.

This is exactly what I needed to know, though I don't see why this can happen.

This may be helpful, or maybe it's not, but this PR also has a commit from another team member. There are two total commits, one from me and one from my teammate.

Maybe. Let's see if we can find the exact combination that can cause this:

• Did you create the PR, or did your colleague?
• Did you make the first commit?
• Did you make the most recent commit?
• Do you and your colleague have the same level of permissions in the repo? What level of permissions do you both have?
• Is this an org-owned repo, or a personal repo?

I can confirm that the email address is correct. I have monitored the GraphQL query with Fiddler, and even recreated the request with the GitHub GraphQL Explorer. It is always the same result, "Invalid email address."

If I remove the authorEmail variable from the graphQL request all together, the merge pull request succeeds.

I'm starting to wonder if this is a Github issue. Can anybody successfully perform a merge pull request with GraphQL while supplying an authorEmail?

To answer your questions:

• I created the PR
• I made the first commit
• I made all commits
• There is no colleague working on this project right now. I created the repo, the commits, and the pull requests.
• This is an Org owned repo.

If I go to github.com and merge the PR, when I click on Merge Pull Request, it says just above the Commit Merge button This commit will be authored by [email protected] and the email address is identical to the one in the logs.

This is exactly what I needed to know, though I don't see why this can happen.

This may be helpful, or maybe it's not, but this PR also has a commit from another team member. There are two total commits, one from me and one from my teammate.

Maybe. Let's see if we can find the exact combination that can cause this:

• Did you create the PR, or did your colleague?
• Did you make the first commit?
• Did you make the most recent commit?
• Do you and your colleague have the same level of permissions in the repo? What level of permissions do you both have?
• Is this an org-owned repo, or a personal repo?

Did you create the PR, or did your colleague?
-- I created
Did you make the first commit?
-- I made first commit
Did you make the most recent commit?
-- Colleague made most recent commit
Do you and your colleague have the same level of permissions in the repo? What level of permissions do you both have?
-- Same. Maintain
Is this an org-owned repo, or a personal repo?
-- Org-owned

Thanks for all the details! I'll try this out with a private, org owned, repo.

I do expect that this is a GitHub issue. I'm just trying to find a way I can repro the issue so I can tell the GitHub folks how to repro it.

Tried with a private, org owned, repo. I still can't repro the issue.

We are experiencing the same issue by all users. Org owned Repo's

Our email is the format Firstname_surname@domain

Works Fine from the web

Tried with a private, org owned, repo. I still can't repro the issue.

Can you grab the API query with Fiddler. Maybe we can compare how it is different.

As mentioned, I grabbed the query being sent to Github and it had what looked like a valid formed request, with the proper email address, yet it still fails when submitting directly. I wonder how your request looks different. Perhaps it is something on the Github side that has to do with a certain repo setting, or what not.

Hey @alexr00, I was able to reproduce this error again with a brand new PR; this time, I was the only contributor.

Private, org-owned, repo, solo contributor.

What do you need from me? 😄

Thanks!

I guess having other contributors to the PR was a red herring.

One more question: when you go to github.com for your repo, is there a little label in the top right that says "GitHub Enterprise", like this?

I have encountered this problem. My details are similar to those described in #5842 (comment). github.com does have the "GitHub Enterprise" label you asked about in the above comment.

I guess having other contributors to the PR was a red herring.

One more question: when you go to github.com for your repo, is there a little label in the top right that says "GitHub Enterprise", like this?

Yes there is.

Yes there is.

github.com does have the "GitHub Enterprise" label you asked about in the above comment.

This is great news. I'll disable this feature for Enterprise. I'm guessing Enterprise just never supports setting an email because you'll only have one email associated with your enterprise account.

The fix has been available in the pre-release version of the extension for a couple days. Could some of the folks in this thread install the pre-release version and let me know if it solves the issue?

@alexr00 this resolved the issue for me. I'm on version v0.89.2024050704 (pre-release).

Thank you! 🙇🏻 🙇🏻

Thanks for verifying and for your patience while I found a fix!

Confirmed working in latest release. Thank you very much.