Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Files" vs "Commits" view for Pullrequest cannot add comments on the "Commit" view #5969

Closed
WybeBosch opened this issue Apr 26, 2024 · 1 comment
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@WybeBosch
Copy link

Context information
- Extension version
0.86.1 (current)
- VSCODE version
github.dev vscode web browser from a git repo activated.
- OS & more
Version: 1.88.1
Date: 2024-04-10T17:36:48.184Z (2 wks ago)
Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/123.0.0.0 Safari/537.36

- Repository Clone Configuration
Single repository
- Github Product (Github.com/Github Enterprise version x.x.x):
Github.com

Steps to Reproduce:

  1. When on a github repo, press the "dot" . key to activate github.dev vscode browser version
  2. When you do this while on a pullrequest, it will open said pull request in the vscode browser version
  3. You then get an extra Tab icon on the side named exactly "Github pull request"

This shows you 2 view options, either a file list of all changed files,
or you can browse each file Per commit
image

  1. I prefer to browse the PR using the "commits" view, but then when you hover over the sidebar, you dont get the option to comment
image

However if you use the "files" view, you do get the option for said + hover to add a comment
image

I can understand that the difference between the file list, and the commit list. Is that the file you are viewing is the "final" version of the file, but it would sure be nice if while browsing the commits from the commitlist i could add the comment there, instead of having to switch back to the filelist, find whatever file i just had open in the commit list and then comment in the place i wanted.

Proposed solution:

  • add the option to add comments to the commitlist aswell
  • To solve the "viewing a file that is different from the final version in the PR" only accept placing comments on files that remain unchanged in the rest of the PR? Since the line numbers would be different if you would want to handle placing comments on older versions of files
@alexr00 alexr00 added the *duplicate Issue identified as a duplicate of another issue(s) label May 2, 2024
@alexr00
Copy link
Member

alexr00 commented May 2, 2024

Duplicate of #4315

@alexr00 alexr00 marked this as a duplicate of #4315 May 2, 2024
@alexr00 alexr00 closed this as completed May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

2 participants