Ctrl+Enter doesn't add comment

[johnknoop]

• Extension version: 0.82.1
• VsCode:
  Version: 1.87.2 (system setup)
  Commit: 863d2581ecda6849923a2118d93a088b0745d9d6
  Date: 2024-03-08T15:20:17.278Z
  Electron: 27.3.2
  ElectronBuildId: 26836302
  Chromium: 118.0.5993.159
  Node.js: 18.17.1
  V8: 11.8.172.18-electron.0
  OS: Windows_NT x64 10.0.22631

Steps to Reproduce:

1. Enter some text into the Reply textbox of a comment
2. Hit ctrl+enter

Expected result:
The reply would be saved

Observed result:
Nothing happens

[alexr00]

I'm not able to reproduce this. Do you have another extension installed that's taking that keybinding. You can check by running the command "Developer: Toggle Keyboard Shortcuts Troubleshooting" and looking at the logs that are shown.

[johnknoop]

I found that the extension GitHub Copilot has added this keyboard shortcut, which was being invoked:

{
  "key": "ctrl+enter",
  "command": "github.copilot.generate",
  "when": "editorTextFocus && github.copilot.activated && !inInteractiveInput && !interactiveEditorFocused"
}

However, I don't understand why the editorTextFocus predicate would be satisfied when it's the comment textbox that has focus. But that would be a VS Code bug, not a bug in your extension so let's not re-open this issue.

[alexr00]

The input where you enter your comment counts as editorTextFocus. Let me see if I can get the Copilot folks to add !commentEditorFocused to their keybinding.

[johnknoop]

Should it really count as an editor though? Isn't that the problem?

[alexr00]

Yes, it is a code editor. This is how we get nice things like markdown syntax highlighting pasting markdown links in the comment widget input.

[alexr00]

Copilot folks have fixed the issue and it should be in one of their upcoming releases.