Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the PR view, the review action selector next to 'Comment' also submits the PR #5896

Open
joshuaobrien opened this issue Apr 4, 2024 · 2 comments
Labels
under-discussion Issue is under discussion for relevance, priority, approach

Comments

@joshuaobrien
Copy link
Contributor

I don't expect the selector to submit the review when I make a selection. Instead, I expect it to change the behaviour of the button next to the dropdown. This has caught me quite a few times. If there's consensus that this would be a better experience, I'd be happy to submit a PR

Kapture.2024-04-04.at.21.32.37.mp4
@alexr00
Copy link
Member

alexr00 commented Apr 5, 2024

There's been some discussion on this before: #3785
The short version is that this is consistent with the behavior in VS Code core in the SCM view.

If there's a strong desire form multiple users to change this then we can add a setting, but my preference would just be to stay consistent with the SCM view.

@joshuaobrien
Copy link
Contributor Author

Makes sense. Thanks for the context

@alexr00 alexr00 added the under-discussion Issue is under discussion for relevance, priority, approach label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

2 participants