Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubeflow Authentication breaks with JupyterLab 4 #15659

Open
TobiasGoerke opened this issue May 3, 2024 · 0 comments
Open

Kubeflow Authentication breaks with JupyterLab 4 #15659

TobiasGoerke opened this issue May 3, 2024 · 0 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@TobiasGoerke
Copy link

TobiasGoerke commented May 3, 2024

With JupyterLab 4.x the /tree path returns a 404 for some reason.
This breaks iff authenticating with a Kubeflow instance in getXSRFToken (link), as the result is expected to be a http 200.

This only applies to Kubeflow instances, for which the sessionCookie param is used see line 205.

I've tried using tokenUrl = new URL('lab', addTrailingSlash(url)).toString(); instead, which works great for JupyterLab 4 Notebooks hosted on Kubeflow.

I'll happily create a PR if this is an appropriate fix. Thanks!

@TobiasGoerke TobiasGoerke added the bug Issue identified by VS Code Team member as probable bug label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

2 participants