Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg|scripts] vcpkg_add_to_path -> add option PREPEND_VCPKG; ADD_ONLY_VCPKG #38391

Open
Neumann-A opened this issue Apr 24, 2024 · 0 comments
Assignees
Labels
category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly

Comments

@Neumann-A
Copy link
Contributor

The idea here is to teach vcpkg_add_to_path to only modify PATH if the path to add is from a vcpkg controlled directory. I observed issues with ninja and python where adding the ninja path to PATH after the python path was added lead to the wrong system python being used (ninja uses PREPEND typically). I think this is a general issue and vcpkg_add_to_path needs to be improved so that we can differentiate between the different use cases and not modify PATH when it is not necessary.

Or we need something like vcpkg_add_program_to_path which inserts the base path of a program into PATH and keeps track of all other invokes to make sure that the changes to PATH does not change base lookup of already added binaries.

@Cheney-W Cheney-W added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly
Projects
None yet
Development

No branches or pull requests

2 participants