Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libxcrypt] Build error on x64-linux #38372

Closed
Hadramet opened this issue Apr 23, 2024 · 1 comment · Fixed by #38376
Closed

[libxcrypt] Build error on x64-linux #38372

Hadramet opened this issue Apr 23, 2024 · 1 comment · Fixed by #38376
Assignees
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist

Comments

@Hadramet
Copy link

Package: libxcrypt:[email protected]

Host Environment

  • Host: x64-linux
  • Compiler: GNU 11.4.0
  • vcpkg-tool version: 2024-03-14-7d353e869753e5609a1f1a057df3db8fd356e49d
    vcpkg-scripts version: 8150939 2024-04-23 (2 hours ago)

To Reproduce

vcpkg install
Failure logs

-- Using cached besser82-libxcrypt-v4.4.36.tar.gz.
-- Cleaning sources at /home/hadramet/dev/vcpkg/buildtrees/libxcrypt/src/v4.4.36-645fb55159.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source /home/hadramet/dev/vcpkg/downloads/besser82-libxcrypt-v4.4.36.tar.gz
-- Using source at /home/hadramet/dev/vcpkg/buildtrees/libxcrypt/src/v4.4.36-645fb55159.clean
-- Getting CMake variables for x64-linux-dbg
-- Getting CMake variables for x64-linux-rel
-- Generating configure for x64-linux
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:112 (message):
    Command failed: /usr/bin/autoreconf -vfi
    Working Directory: /home/hadramet/dev/vcpkg/buildtrees/libxcrypt/src/v4.4.36-645fb55159.clean/
    Error code: 1
    See logs for more information:
      /home/hadramet/dev/vcpkg/buildtrees/libxcrypt/autoconf-x64-linux-err.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_configure_make.cmake:728 (vcpkg_execute_required_process)
  buildtrees/versioning_/versions/libxcrypt/85a0274aca1b0c7bf756cb41f77d9dbfc2b6fb78/portfile.cmake:10 (vcpkg_configure_make)
  scripts/ports.cmake:175 (include)



/home/hadramet/dev/vcpkg/buildtrees/libxcrypt/autoconf-x64-linux-err.log
autoreconf: export WARNINGS=
autoreconf: Entering directory '.'
autoreconf: configure.ac: not using Gettext
autoreconf: running: aclocal --force -I build-aux/m4
autoreconf: configure.ac: tracing
autoreconf: configure.ac: not using Libtool
autoreconf: configure.ac: not using Intltool
autoreconf: configure.ac: not using Gtkdoc
autoreconf: running: /usr/bin/autoconf --force
configure.ac:86: warning: LT_PATH_NM is m4_require'd but not m4_defun'd
build-aux/m4/zw_detect_asan.m4:18: zw_ASAN_IFELSE is expanded from...
lib/m4sugar/m4sh.m4:692: _AS_IF_ELSE is expanded from...
lib/m4sugar/m4sh.m4:699: AS_IF is expanded from...
./lib/autoconf/general.m4:2249: AC_CACHE_VAL is expanded from...
./lib/autoconf/general.m4:2270: AC_CACHE_CHECK is expanded from...
configure.ac:86: the top level
autoreconf: running: /usr/bin/autoheader --force
autoreconf: running: automake --add-missing --copy --force-missing
configure.ac:30: installing 'build-aux/m4-autogen/compile'
configure.ac:29: installing 'build-aux/m4-autogen/config.guess'
configure.ac:29: installing 'build-aux/m4-autogen/config.sub'
configure.ac:16: installing 'build-aux/m4-autogen/install-sh'
configure.ac:16: installing 'build-aux/m4-autogen/missing'
Makefile.am: installing './INSTALL'
Makefile.am:97: error: Libtool library used but 'LIBTOOL' is undefined
Makefile.am:97:   The usual way to define 'LIBTOOL' is to add 'LT_INIT'
Makefile.am:97:   to 'configure.ac' and run 'aclocal' and 'autoconf' again.
Makefile.am:97:   If 'LT_INIT' is in 'configure.ac', make sure
Makefile.am:97:   its definition is in aclocal's search path.
Makefile.am: installing 'build-aux/m4-autogen/depcomp'
parallel-tests: installing 'build-aux/m4-autogen/test-driver'
autoreconf: error: automake failed with exit status: 1

Additional context

vcpkg.json
{
  "name": "some-project",
  "version-string": "1.0.0",
  "builtin-baseline": "345ac44ab8d6a16239d3af55df9608bf725e7a48",
  "dependencies": [
    {
      "name": "gtest",
      "version>=": "1.14.0"
    },
    {
      "name": "kenlm",
      "version>=": "20230531#1"
    },
    {
      "name": "spdlog",
      "version>=": "1.13.0"
    },
    {
      "name": "abseil",
      "version>=": "20230802.1"
    },
    {
      "name": "opencv",
      "version>=": "4.8.0#1"
    },
    {
      "name": "yaml-cpp",
      "version>=": "0.8.0#1"
    },
    {
      "name": "nlohmann-json",
      "version>=": "3.11.3"
    },
    {
      "name": "glib",
      "version>=": "2.78.4#1"
    },
    {
      "name": "libxcrypt",
      "version>=": "4.4.36"
    }
  ]
}

@Hadramet
Copy link
Author

Found a way to fix this error by installing libtool (also might fail if no autoconf )

sudo apt-get -y install libtool

@WangWeiLin-MV WangWeiLin-MV added the category:port-bug The issue is with a library, which is something the port should already support label Apr 24, 2024
@WangWeiLin-MV WangWeiLin-MV added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist and removed category:port-bug The issue is with a library, which is something the port should already support labels Apr 24, 2024
data-queue pushed a commit that referenced this issue Apr 30, 2024
Fix #38372

Add message of build requirements `autoconf` `automake` `libtool`
`pkg-config` from [upstream
README](https://github.com/besser82/libxcrypt?tab=readme-ov-file#build-requirements-and-instructions)

### Checklist
- [x] Changes comply with the [maintainer
guide](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md).
- [ ] ~SHA512s are updated for each updated download.~
- [ ] ~The "supports" clause reflects platforms that may be fixed by
this new version.~
- [ ] ~Any fixed [CI
baseline](https://github.com/microsoft/vcpkg/blob/master/scripts/ci.baseline.txt)
entries are removed from that file.~
- [ ] ~Any patches that are no longer applied are deleted from the
port's directory.~
- [x] The version database is fixed by rerunning `./vcpkg x-add-version
--all` and committing the result.
- [x] Only one version is added to each modified port's versions file.

### Test
Port install tests pass with following triplets:
* x64-linux
yurybura pushed a commit to yurybura/vcpkg that referenced this issue May 8, 2024
Fix microsoft#38372

Add message of build requirements `autoconf` `automake` `libtool`
`pkg-config` from [upstream
README](https://github.com/besser82/libxcrypt?tab=readme-ov-file#build-requirements-and-instructions)

### Checklist
- [x] Changes comply with the [maintainer
guide](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md).
- [ ] ~SHA512s are updated for each updated download.~
- [ ] ~The "supports" clause reflects platforms that may be fixed by
this new version.~
- [ ] ~Any fixed [CI
baseline](https://github.com/microsoft/vcpkg/blob/master/scripts/ci.baseline.txt)
entries are removed from that file.~
- [ ] ~Any patches that are no longer applied are deleted from the
port's directory.~
- [x] The version database is fixed by rerunning `./vcpkg x-add-version
--all` and committing the result.
- [x] Only one version is added to each modified port's versions file.

### Test
Port install tests pass with following triplets:
* x64-linux
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants