Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.21] clearing marks seems to have regressed #17130

Closed
zadjii-msft opened this issue Apr 25, 2024 · 0 comments · Fixed by #17144
Closed

[1.21] clearing marks seems to have regressed #17130

zadjii-msft opened this issue Apr 25, 2024 · 0 comments · Fixed by #17144
Assignees
@zadjii-msft
Labels
In-PR This issue has a related PR Needs-Tag-Fix Doesn't match tag requirements Severity-Blocking We won't ship a release like this! No-siree.
Milestone
Terminal v1.21

Comments

@zadjii-msft
Copy link
Member

I know that I'm the murderer, just haven't debugged why yet

undoubtably regressed in #16937
@zadjii-msft zadjii-msft added this to the Terminal v1.21 milestone Apr 25, 2024
@zadjii-msft zadjii-msft added the Severity-Blocking We won't ship a release like this! No-siree. label Apr 25, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 25, 2024
@carlos-zamora carlos-zamora removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Apr 25, 2024
@zadjii-msft zadjii-msft mentioned this issue Apr 26, 2024
Merged
@zadjii-msft zadjii-msft added the In-PR This issue has a related PR label Apr 29, 2024
DHowett pushed a commit that referenced this issue May 2, 2024
@zadjii-msft
Fix clearing marks (#17144)
92e05f2 
Tests are good, I should write more of them. 


Closes #17130
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zadjii-msft zadjii-msft

Labels
In-PR This issue has a related PR Needs-Tag-Fix Doesn't match tag requirements Severity-Blocking We won't ship a release like this! No-siree.
Projects
None yet
Milestone
Terminal v1.21
Development

Successfully merging a pull request may close this issue.

Fix clearing marks microsoft/terminal
2 participants
@carlos-zamora @zadjii-msft