Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.21.1094 Canary] Terminal hangs and crashes when closed. #17112

Closed
AvogatoWizardWhisker opened this issue Apr 23, 2024 · 8 comments
Closed
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-No-Repro We couldn't get this to happen, or it stopped happening entirely. Severity-Crash Crashes are real bad news.

Comments

@AvogatoWizardWhisker
Copy link

Windows Terminal version

1.21.1094

Windows build number

10.0.26200.5001

Other Software

No response

Steps to reproduce

  • Open Terminal.
  • Do so work with the command linen with multiple tabs open.
  • Close window.
Recording.2024-04-23.193528.mp4

Expected Behavior

Terminal with multiple or single tabs should close normally.

Actual Behavior

At a rare circumstance, Terminal hangs for a moment then crashes. The following files are my current for Terminal Canary. I hope that helps.

state.json

settings.json

@AvogatoWizardWhisker AvogatoWizardWhisker added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Apr 23, 2024
Copy link

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!

Closed similar issues:

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

@carlos-zamora carlos-zamora added the Severity-Crash Crashes are real bad news. label Apr 25, 2024
@carlos-zamora
Copy link
Member

Thanks for filing! Even if you can't reproduce it on demand, can you file feedback via feedback hub for us just to get it in the system /?

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Apr 25, 2024
@AvogatoWizardWhisker
Copy link
Author

Certainly. Although the build has now been updated to version 1.21.1153.0, it's unclear if the issue still exists. I'll go ahead and report this in the Feedback Hub regardless.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Apr 25, 2024
@carlos-zamora
Copy link
Member

Cool! Sorry to do this a week late, but when you do, can you share that feedback hub link with us? Thanks!

@carlos-zamora carlos-zamora added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Attention The core contributors need to come back around and look at this ASAP. labels May 1, 2024
@AvogatoWizardWhisker
Copy link
Author

Sure thing
https://aka.ms/AAq9yye

image

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels May 3, 2024
@lhecker
Copy link
Member

lhecker commented May 3, 2024

Do you remember when the crash happened last time? Also, how did you recognize it as a crash? Unless I'm mistaken, there aren't any Windows Terminal crash reports for your device, nor anything related inside your feedback data that indicates a Windows Terminal crashed in recent times.
(If anyone else on the team got time, it'd be nice if you could double check me.)

Edit: If you have a debugger like WinDbg or Visual Studio set to pop up when a crash occurs, it will prevent the OS from saving a crash dump. This would explain why I couldn't find any crash reports for Windows Terminal. If you do use a debugger like that, it'd be nice if you could save a dump next time it happens and send it to us!

@AvogatoWizardWhisker
Copy link
Author

AvogatoWizardWhisker commented May 3, 2024

I first experienced this crash issue since 20th April. I knew it was a crash because the terminal hangs for a bit, then it closed. Which is not good when i had multiple windows open. And i can confirm It was indeed a crash right after i checked in Windows' Reliability History. I wanted to send a dump file or anything containing errors and such, but it didn't generate any file.

image

Same story with Event Viewer

image

Edit: I'm now in version 1.21.1201.0. For now, the terminal doesn't crash at close. It appears it has been fixed. Especially with the duplicate tab issue mentioned.

@carlos-zamora
Copy link
Member

I'm now in version 1.21.1201.0. For now, the terminal doesn't crash at close. It appears it has been fixed. Especially with the duplicate tab issue mentioned.

Great! Thanks for working with us. Closing since it appears fixed 😊

@zadjii-msft zadjii-msft added the Resolution-No-Repro We couldn't get this to happen, or it stopped happening entirely. label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-No-Repro We couldn't get this to happen, or it stopped happening entirely. Severity-Crash Crashes are real bad news.
Projects
None yet
Development

No branches or pull requests

4 participants