Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open new tab icon at the top title is not centered correctly #17091

Open
Emirhan-7274 opened this issue Apr 20, 2024 · 1 comment
Open

open new tab icon at the top title is not centered correctly #17091

Emirhan-7274 opened this issue Apr 20, 2024 · 1 comment
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Milestone

Comments

@Emirhan-7274
Copy link

Windows Terminal version

1.19.10821.0

Windows build number

10.0.22631.3447

Other Software

No response

Steps to reproduce

Ekran görüntüsü 2024-04-20 151314

its hard to notice it but if you set "Use acrylic material in the tab row" to true it becomes highly noticable

Expected Behavior

open a new tab icon to be centered

Actual Behavior

open a new tab icon is not centered

@Emirhan-7274 Emirhan-7274 added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Apr 20, 2024
@Emirhan-7274 Emirhan-7274 changed the title at the top title is not centered correctly create new tab icon at the top title is not centered correctly Apr 20, 2024
@Emirhan-7274 Emirhan-7274 changed the title create new tab icon at the top title is not centered correctly open new tab icon at the top title is not centered correctly Apr 20, 2024
@zadjii-msft
Copy link
Member

Huh, good eye.

Code is somewhere around here:

<mux:TabView.TabStripFooter>
<Grid>
<!-- Remove this border after WinUI 2.8 -->
<Border Height="1"
VerticalAlignment="Bottom"
Background="{ThemeResource CardStrokeColorDefaultBrush}" />
<mux:SplitButton x:Name="NewTabButton"
x:Uid="NewTabSplitButton"
Height="24"
Margin="0,4"
Padding="0"
HorizontalAlignment="Left"
VerticalAlignment="Stretch"
AllowDrop="True"
AutomationProperties.AccessibilityView="Control"
BorderThickness="0"
Click="OnNewTabButtonClick"
Content="&#xE710;"
DragOver="OnNewTabButtonDragOver"
Drop="OnNewTabButtonDrop"
FontFamily="{ThemeResource SymbolThemeFontFamily}"
FontSize="12">

IIRC we're adding some margin to make the + centered nicely, but that code hasn't been touched in years so I may be off base on that

@carlos-zamora carlos-zamora added Help Wanted We encourage anyone to jump in on these. Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. Priority-3 A description (P3) and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Apr 25, 2024
@carlos-zamora carlos-zamora added this to the Backlog milestone Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

3 participants