Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider using a "system message" after a session restore, instead of ^[2J to clear the screen #17074

Closed
carlos-zamora opened this issue Apr 16, 2024 · 1 comment · Fixed by #17113
Closed

Consider using a "system message" after a session restore, instead of ^[2J to clear the screen #17074

carlos-zamora opened this issue Apr 16, 2024 · 1 comment · Fixed by #17113
Assignees
@lhecker
Labels
Area-Output Related to output processing (inserting text into buffer, retrieving buffer text, etc.) Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Milestone
Terminal v1.21

Comments

@carlos-zamora
Copy link
Member

v1.20.11072.0 (bug bash on 4/16)

Consideration: we could use conpty inherit cursor mode
@carlos-zamora carlos-zamora added the Product-Terminal The new Windows Terminal. label Apr 16, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Apr 16, 2024
@lhecker lhecker self-assigned this Apr 16, 2024
@carlos-zamora carlos-zamora added this to the Terminal v1.21 milestone Apr 17, 2024
@carlos-zamora carlos-zamora added Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Area-Output Related to output processing (inserting text into buffer, retrieving buffer text, etc.) and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 17, 2024
@lhecker lhecker mentioned this issue Apr 23, 2024
Merged
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Apr 24, 2024
@lhecker
Copy link
Member

lhecker commented Apr 24, 2024

Reopening for me as a reminder to address the remaining issue of the status message marking 2 lines as gray (#17117 (comment)).

@lhecker lhecker reopened this Apr 24, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Tag-Fix Doesn't match tag requirements label Apr 24, 2024
@lhecker lhecker mentioned this issue May 2, 2024
Merged
DHowett pushed a commit that referenced this issue May 2, 2024
@lhecker
Fix remaining buffer serialization bugs (#17182)
d4faf98 
It may be more accurate to say: "Fix _known_ remaining buffer
serialization bugs", but I'll try to be positive about my code.

Initially, the buffer is initialized with the default attributes,
but once it begins to scroll, newly scrolled in rows are initialized
with the current attributes. This means we need to set the current
attributes to those of the upcoming row before the row comes up.

This is related to #17074.

## Validation Steps Performed
* Persist and restore a buffer 10 times
* All previous "Restore" status messages look correct ✅
* The escape sequences in the buffer file look correct ✅
@lhecker lhecker closed this as completed May 3, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lhecker lhecker

Labels
Area-Output Related to output processing (inserting text into buffer, retrieving buffer text, etc.) Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Terminal v1.21
Development

Successfully merging a pull request may close this issue.

Add a system message to session restore microsoft/terminal
2 participants
@lhecker @carlos-zamora