Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.21] You can have a restored settings tab and open a second settings tab #17070

Closed
DHowett opened this issue Apr 16, 2024 · 3 comments · Fixed by #17169
Closed

[1.21] You can have a restored settings tab and open a second settings tab #17070

DHowett opened this issue Apr 16, 2024 · 3 comments · Fixed by #17169
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree.

Comments

@DHowett
Copy link
Member

DHowett commented Apr 16, 2024

Windows Terminal version

1.21.1011.0

Windows build number

No response

Other Software

No response

Steps to reproduce

Enable session restoration.

Open settings.

Close terminal.

Relaunch terminal.

Open settings again.

Expected Behavior

No response

Actual Behavior

image

@DHowett DHowett added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Apr 16, 2024

This comment was marked as off-topic.

@DHowett
Copy link
Member Author

DHowett commented Apr 16, 2024

You can do this an infinite number of times!

@DHowett
Copy link
Member Author

DHowett commented Apr 16, 2024

@zadjii-msft hah actually this applies to any newTab type:settings action. You can just keep doing it

@zadjii-msft zadjii-msft added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Area-Settings Issues related to settings and customizability, for console or terminal Product-Terminal The new Windows Terminal. labels Apr 16, 2024
@zadjii-msft zadjii-msft added this to the Terminal v1.21 milestone Apr 16, 2024
@carlos-zamora carlos-zamora removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Apr 17, 2024
@zadjii-msft zadjii-msft added the Severity-Blocking We won't ship a release like this! No-siree. label Apr 23, 2024
github-merge-queue bot pushed a commit that referenced this issue May 2, 2024
Re-add some machinery to special case settings tabs. When we're going to
persist a tab that only has a single settings pane in it, we'll now
promote that to the first-class "openSettings" action. This will allow
our other code in TerminalPage to route multiple settings tabs all to
the same tab.

This of course doesn't stop you from opening multiple settings tabs with
`{ "command": {"action": "newTab", "type": "settings"} }` actions. If we
did that, then that would prevent someone from having a settings pane in
the first pane, and a terminal to the right.

Closes #17070
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants