Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STILL Can't bypass DOSkey macro with leading space #16875

Closed
cniggeler opened this issue Mar 14, 2024 · 10 comments
Closed

STILL Can't bypass DOSkey macro with leading space #16875

cniggeler opened this issue Mar 14, 2024 · 10 comments
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting

Comments

@cniggeler
Copy link

Windows Terminal version

1.19.10573.0

Windows build number

10.0.22621.3296

Other Software

No response

Steps to reproduce

Please see #4189. It is the exactly the same. This was merged with #13476 which was closed-fixed, but it is not fixed. Since I can't reopen 4189 I've created a new one here per github rules.

Expected Behavior

If you put a space before a DOSKey macro that has the same name as a built-in command, the built-in command is supposed to run.

Actual Behavior

The DOSKey macro runs.

@cniggeler cniggeler added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Mar 14, 2024
Copy link

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!

Open similar issues:

Closed similar issues:

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

@DHowett

This comment was marked as resolved.

@DHowett
Copy link
Member

DHowett commented Mar 14, 2024

@cniggeler weird! I absolutely can bypass DOSkey macros with a leading space.

image

image

Can you share more information about your setup?

@DHowett DHowett added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Mar 14, 2024
@DHowett
Copy link
Member

DHowett commented Mar 14, 2024

FWIW, from the exact repro steps

image

@cniggeler
Copy link
Author

Here's what I get. Laptop, converted Win-11 S mode to Win 11 Home.
doskey

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Mar 14, 2024
@lhecker
Copy link
Member

lhecker commented Mar 14, 2024

That's certainly not Windows Terminal 1.19.10573.0 as you mentioned in your issue though. The older Windows Console Host that you're using only gets updates every couple years whenever there's a major Windows update. The next update will come out later this year and will have the fix.

@cniggeler
Copy link
Author

My bad. I thought that conhost was a part of terminal. I have opened a wt.exe session with default Command Prompt and the space in front of the command does work as it should! Closing this ticket...

@iamqiz
Copy link

iamqiz commented Apr 9, 2024

the issue still exist in terminal preview 1.20.10822.0
Clip_2024-04-09_21-06-48

@iamqiz
Copy link

iamqiz commented Apr 9, 2024

@DHowett the first "dir" is "dir /b"
the second "dir" is original dir
they are not same

@DHowett
Copy link
Member

DHowett commented Apr 9, 2024

@iamqiz you demonstrated bypassing the alias abc by putting a space in front of it. That is the intended behavior. The bug in this report was that it did not work. It works now. The dir example is the same premise.

If you are having an issue which is not “I cannot bypass an alias by adding a space in front of it”, please file a new bug.

@microsoft microsoft locked as resolved and limited conversation to collaborators Apr 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting
Projects
None yet
Development

No branches or pull requests

4 participants