Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localization - Typos/consistency errors in French in closing contextual menu #16819

Open
SphinxKnight opened this issue Mar 5, 2024 · 2 comments
Open

Localization - Typos/consistency errors in French in closing contextual menu #16819

SphinxKnight opened this issue Mar 5, 2024 · 2 comments
Assignees
@lhecker
Labels
Area-Localization Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Milestone
Terminal v1.21

Comments

@SphinxKnight
Copy link

Windows Terminal version

1.19.10573.0

Windows build number

10.0.19045.4046

Other Software

No response

Steps to reproduce

Open the Terminal (splitting the tab helps discover one more string)

Expected Behavior

The contextual menu should contain "Fermer" (infinitive) and not "Fermez" (imperative)
Submenu should contain "Fermer les onglets à droite" / "Fermer les autres onglets" / "Fermer le volet"

Actual Behavior

Casing and conjugation are inconsistent

Conjugation: a mix of infinitive and imperative while the rest of the UI is, correctly, using infinitive
image

Casing: those strings are using uppercase starting words while the rest of the UI is, correctly, using an uppercase letter only for the first letter of the text
@SphinxKnight SphinxKnight added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Mar 5, 2024
@SphinxKnight SphinxKnight changed the title Localization - Typos/consistency errors in French Localization - Typos/consistency errors in French in closing contextual menu Mar 5, 2024
@carlos-zamora carlos-zamora added Product-Terminal The new Windows Terminal. Area-Localization and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Mar 6, 2024
@carlos-zamora carlos-zamora modified the milestones: Backlog, Terminal v1.21 Mar 6, 2024
@PhMajerus
Copy link

PhMajerus commented Mar 8, 2024 •
edited

Just to clarify the expected behavior, the cascading menu item also needs to be fixed:

Fermer… >
     Fermer les onglets à droite
     Fermer les autres onglets
     Fermer le volet
Fermer l'onglet

The uppercases of some items seems weird to me even in English, but if you want to keep them and want French to be consistent with other languages:

Fermer… >
     Fermer les Onglets à Droite
     Fermer les Autres onglets
     Fermer le Volet
Fermer l'onglet

(note the Pane/volet is currently using uppercase in English but lowercase in French)

To be fair, it feels weird in English as well, and just looks even worse in French because it is applied only to some menu items and because determiners make them lose their left alignments, making it worse visually.

Oh, and those … are not consistent with Windows UI guidelines and have to go, see #16846.

@PhMajerus PhMajerus mentioned this issue Mar 8, 2024
Closed
@HarshNarayanJha HarshNarayanJha mentioned this issue Mar 17, 2024
Merged
4 tasks
github-merge-queue bot pushed a commit that referenced this issue Apr 10, 2024
@HarshNarayanJha
Fix: UI style errors: Menu items capitalization and … (ellipses) mark…
8bd9578 
… misuse (#16886)

I changed the improper capitalization and misuse of ellipses mark (...)
in the context menu and various other places.

Fixes issues #16819 and #16846

## PR Checklist
- [ ] Closes #16846
- [x] Tests added/passed - NA
- [x] Documentation updated - NA
- If checked, please file a pull request on [our docs
repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx
- [x] Schema updated (if necessary) - NA
DHowett pushed a commit that referenced this issue Apr 16, 2024
@HarshNarayanJha @DHowett
Fix: UI style errors: Menu items capitalization and … (ellipses) mark…
485b4ab 
… misuse (#16886)

I changed the improper capitalization and misuse of ellipses mark (...)
in the context menu and various other places.

Fixes issues #16819 and #16846

## PR Checklist
- [ ] Closes #16846
- [x] Tests added/passed - NA
- [x] Documentation updated - NA
- If checked, please file a pull request on [our docs
repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx
- [x] Schema updated (if necessary) - NA

(cherry picked from commit 8bd9578)
Service-Card-Id: 92350387
Service-Version: 1.20
DHowett pushed a commit that referenced this issue Apr 16, 2024
@HarshNarayanJha @DHowett
Fix: UI style errors: Menu items capitalization and … (ellipses) mark…
3a9024b 
… misuse (#16886)

I changed the improper capitalization and misuse of ellipses mark (...)
in the context menu and various other places.

Fixes issues #16819 and #16846

## PR Checklist
- [ ] Closes #16846
- [x] Tests added/passed - NA
- [x] Documentation updated - NA
- If checked, please file a pull request on [our docs
repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx
- [x] Schema updated (if necessary) - NA

(cherry picked from commit 8bd9578)
Service-Card-Id: 92350386
Service-Version: 1.19
@lhecker
Copy link
Member

lhecker commented May 17, 2024

The fermer vs. fermez issue does seem resolved now. I'm not entirely sure either whether capitalizing Pane in French is a good idea. It's a little weird even in the English original IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lhecker lhecker

Labels
Area-Localization Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Terminal v1.21
Development

No branches or pull requests
4 participants
@lhecker @SphinxKnight @carlos-zamora @PhMajerus