New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bad default selection background color with light schemes #8716
Comments
Okay, you're not wrong here. Part of the trick with these schemes is that they don't canonically include a selection color. Usually, they're just defined as a set of (foreground, background, 16-color table). The selection color is almost always just set by the terminal emulator. So if we were to add selection BG colors to these schemes, that would be some other customization that we're making to these schemes other than their usual definitions. Though, I think I agree - until #3561 lands, the experience with these themes is just bad. I wonder if we could just use the "bright black" color for each of these schemes and have it work good enough.
Go through each of the "light" color schemes in This will probably end up in a team discussion, but it'll be helpful to have a concrete example to drive that discussion. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Add a selectionBackground property which is set to the scheme's brightBlack too all 3 of the light color schemes. Related to #8716 It does not close the bug because as mentioned in the issue, when you input numbers, they seem to be invisible in the light color schemes and selecting them with the cursor doesn't reveal them.
Add a selectionBackground property which is set to the scheme's brightBlack too all 3 of the light color schemes. Related to #8716 It does not close the bug because as mentioned in the issue, when you input numbers, they seem to be invisible in the light color schemes and selecting them with the cursor doesn't reveal them. (cherry picked from commit a5c269b) Service-Card-Id: 91033166 Service-Version: 1.18
Add a selectionBackground property which is set to the scheme's brightBlack too all 3 of the light color schemes. Related to #8716 It does not close the bug because as mentioned in the issue, when you input numbers, they seem to be invisible in the light color schemes and selecting them with the cursor doesn't reveal them. (cherry picked from commit a5c269b) Service-Card-Id: 91033167 Service-Version: 1.19
Add a selectionBackground property which is set to the scheme's brightBlack too all 3 of the light color schemes. Related to #8716 It does not close the bug because as mentioned in the issue, when you input numbers, they seem to be invisible in the light color schemes and selecting them with the cursor doesn't reveal them. (cherry picked from commit a5c269b) Service-Card-Id: 91033166 Service-Version: 1.18
Add a selectionBackground property which is set to the scheme's brightBlack too all 3 of the light color schemes. Related to microsoft#8716 It does not close the bug because as mentioned in the issue, when you input numbers, they seem to be invisible in the light color schemes and selecting them with the cursor doesn't reveal them.
## Summary of the Pull Request Fixed default selection background colors with light schemes. Default color now matches the scheme and contrasts well ## References and Relevant Issues none ## Detailed Description of the Pull Request / Additional comments This is my first contribution ever :) Even though its simple, im happy to help ## Validation Steps Performed ## PR Checklist - [ ] Closes #8716 - [ ] Tests added/passed - [ ] Documentation updated - If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx - [ ] Schema updated (if necessary)
Environment
Steps to reproduce
One Half Light
,Solarized Light
, orTango Light
color schemes.Expected behavior
It's easy to see which text was selected.
Actual behavior
It's hard to see which text was selected because the default selectionBackground value is white, and that doesn't work well with light color schemes.
Proposed solution
Add selectionBackground values to all of the color schemes in defaults.json (or at least the light color schemes).
Related to
This issue is related to #3326, #3561, and #3580.
The text was updated successfully, but these errors were encountered: