-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SUGGESTION] Can we also include @types/xyz dependencies in align-deps #2398
Comments
submit a PR? |
@kelset sure I can submit a PR but before I did that i wanted to confirm if you folks also think that this will be a meaningful addition. |
I think it makes sense to add it. My only concern is that we should not make the |
Yeah. Makes sense. We can maybe add "types" as a capability. If "types" is listed as a capability, the tool will check/include typings for required packages. What do you think? |
I think that will require a lot more work and no longer makes the core engine generic. If we just add a |
What happened?
I have seen quite often that people who use rnx-kit/align-deps, update their dependencies properly as align-deps does it for them. But they often forget to update the type dependencies.
For example,
with React: 18.x.x we should use @types/React: 18.x.x.
with ReactNative: 0.71.x, we do not need types/react-native as types are already included.
There could be merit in configuring align-deps to factor in these dependencies as well.
Affected Package
@rnx-kit/align-deps
Version
2.2.0
Which platforms are you seeing this issue on?
System Information
Steps to Reproduce
NA
Code of Conduct
The text was updated successfully, but these errors were encountered: