Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass production & development requirements in @rnx-kit/align-deps's cli() & --requirements flag #2142

Open
AlekhyaYalla opened this issue Jan 24, 2023 · 0 comments
Labels
enhancement New feature or request feature: align-deps This is related to align-deps good first issue Good for newcomers

Comments

@AlekhyaYalla
Copy link

In dep-check-> cli() function accepts the parameter --vigilant. This param takes a string, where the first one is considered as reactNativeDevVersion & rest of them are considered as reactNativeVersion fields in reference to the dep-check package-level config. 
In align-deps, the --requirements field is the replacement of the --vigilant param. But how do we pass the requirements into cli() function or --requirements flag which will be used for/as production & development fields in align-deps package-level config.

When using the align-deps in monorepo, and running the tool using cli() funciton or using --requirements flag in yarn rnx-align-deps , I dont have any possible way to pass the "production" requirements which will align "peerDependencies" section of package.json(s). Having package-level configurations is not so feasible in our case as the number of packages is very high in number.
It would be really nice to have the ability to pass the requirements with "production" & "development" fields or a way to do it.

Affected Package

@rnx-kit/align-deps

Version

2.0.3

Steps to Reproduce

Run the yarn rnx-align-deps --requirements [email protected] --presets "path-to-my-preset` in a monorepo. this will only align the dependencies in the dependencies & dev dependencies section. peer dependencies are not aligned.

@ghost ghost added the needs triage 🔍 label Jan 24, 2023
@tido64 tido64 added enhancement New feature or request good first issue Good for newcomers feature: align-deps This is related to align-deps and removed needs triage 🔍 labels Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature: align-deps This is related to align-deps good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants