-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unfork JSRuntimeFactory Files #13172
Milestone
Comments
microsoft-github-policy-service
bot
added
the
Needs: Triage 🔍
New issue that needs to be reviewed by the issue management team (label applied by bot)
label
May 1, 2024
Based on |
chrisglein
added
enhancement
and removed
bug
Needs: Triage 🔍
New issue that needs to be reviewed by the issue management team (label applied by bot)
labels
May 6, 2024
This was referenced May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem Description
Recent integration brought in this PR which added the method getRuntimeTargetDelegate to JSRuntime and changes how we pass the RuntimeTarget. HermesRuntime does not implement this method but because it's a virtual method, Hermes needs too if we want to unfork these files.
Current Forked Files
Currently these files are set to an older version in the integration.
Steps To Reproduce
Error LNK2001 unresolved external symbol "public: virtual class facebook::react::jsinspector_modern::RuntimeTargetDelegate & __cdecl facebook::react::JSRuntime::getRuntimeTargetDelegate(void)" (?getRuntimeTargetDelegate@JSRuntime@react@facebook@@UEAAAEAVRuntimeTargetDelegate@jsinspector_modern@23@XZ) Microsoft.ReactNative D:\react-native-windows\vnext\Microsoft.ReactNative\HermesRuntimeHolder.obj
Expected Results
Should not get an error message
CLI version
npx react-native -v
Environment
Target Platform Version
10.0.22321
Target Device(s)
Desktop
Visual Studio Version
Visual Studio 2022
Build Configuration
Debug
Snack, code example, screenshot, or link to a repository
No response
The text was updated successfully, but these errors were encountered: