Add option to specify timestamp type #189
Comments
pierricgimmig
added a commit
to pierricgimmig/orbit
that referenced
this issue
Feb 10, 2022
Use PROCESS_TRACE_MODE_RAW_TIMESTAMP when setting up the ETW trace so that timestamps are not converted int system time but rather kept in their original format, in our case, the format that matches QueryPerformanceCounter timestamps. Log the state of the ETW trace file when starting a capture to confirm the timestamp format change took place. An issue was opened upstream in the krabsetw repo: microsoft/krabsetw#189 Test: locally tested, instrumented scopes now align with call stack samples and scheduling events.
pierricgimmig
added a commit
to pierricgimmig/orbit
that referenced
this issue
Feb 10, 2022
Use PROCESS_TRACE_MODE_RAW_TIMESTAMP when setting up the ETW trace so that timestamps are not converted int system time but rather kept in their original format, in our case, the format that matches QueryPerformanceCounter timestamps. Keep a copy of EVENT_TRACE_LOGFILE object returned by krabsetw so that we can inspect its state and make sure the clock type is the one we expect. A change logging this data structure will come in another PR but we can already inspect the value of the log file structure in a debugger. An issue was opened upstream in the krabsetw repo: microsoft/krabsetw#189 Test: locally tested, instrumented scopes now align with call stack samples and scheduling events.
pierricgimmig
added a commit
to pierricgimmig/orbit
that referenced
this issue
Feb 10, 2022
Use PROCESS_TRACE_MODE_RAW_TIMESTAMP when setting up the ETW trace so that timestamps are not converted int system time but rather kept in their original format, in our case, the format that matches QueryPerformanceCounter timestamps. Keep a copy of EVENT_TRACE_LOGFILE object returned by krabsetw so that we can inspect its state and make sure the clock type is the one we expect. A change logging this data structure will come in another PR but we can already inspect the value of the log file structure in a debugger. An issue was opened upstream in the krabsetw repo: microsoft/krabsetw#189 Test: locally tested, instrumented scopes now align with call stack samples and scheduling events.
pierricgimmig
added a commit
to pierricgimmig/orbit
that referenced
this issue
Feb 10, 2022
Use PROCESS_TRACE_MODE_RAW_TIMESTAMP when setting up the ETW trace so that timestamps are not converted int system time but rather kept in their original format, in our case, the format that matches QueryPerformanceCounter timestamps. Keep a copy of EVENT_TRACE_LOGFILE object returned by krabsetw so that we can inspect its state and make sure the clock type is the one we expect. A change logging this data structure will come in another PR but we can already inspect the value of the log file structure in a debugger. An issue was opened upstream in the krabsetw repo: microsoft/krabsetw#189 Test: locally tested, instrumented scopes now align with call stack samples and scheduling events.
pierricgimmig
added a commit
to google/orbit
that referenced
this issue
Feb 10, 2022
Use PROCESS_TRACE_MODE_RAW_TIMESTAMP when setting up the ETW trace so that timestamps are not converted into system time but rather kept in their original format, in our case, the format that matches QueryPerformanceCounter timestamps. Keep a copy of EVENT_TRACE_LOGFILE object returned by krabsetw so that we can inspect its state and make sure the clock type is the one we expect. A change logging this data structure will come in another PR but we can already inspect the value of the log file structure in a debugger. An issue was opened upstream in the krabsetw repo: microsoft/krabsetw#189 Test: locally tested, instrumented scopes now align with call stack samples and scheduling events.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
By default, krabsetw produces events that have their timestamps converted into system time. Specifying
PROCESS_TRACE_MODE_RAW_TIMESTAMPasProcessTraceModein theEVENT_TRACE_LOGFILEwould leave timestamps in the same raw format used byQueryPerformanceCounter(). This is desirable as there is less overhead per timestamp but would also be particularly useful to correlate krabsetw events to other profiling events timestamped with theQueryPerformanceCounter()API. Adding an option to select the timestamp type would be great.See https://docs.microsoft.com/en-us/windows/win32/api/evntrace/ns-evntrace-event_trace_logfilea for more details.
The text was updated successfully, but these errors were encountered: