You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I added a Wrapper to Button.test.tsx in react-button that doesn't render the button component and the make-styles-overrides-win still passes.
Bug Description
Actual Behavior
The make-styles-overrides-win conformance test in react-conformance-griffel directly renders the Component given and ignores the renderOptions: { wrapper: _ } option.
Expected Behavior
The call to ReactDOM.render(element, container); should pass the wrapper option if provided. This would allow components that require an external context to be tested.
Logs
No response
Requested priority
Normal
Products/sites affected
No response
Are you willing to submit a PR to fix?
no
Validations
Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
The provided reproduction is a minimal reproducible example of the bug.
The text was updated successfully, but these errors were encountered:
Library
React Components / v9 (@fluentui/react-components)
System Info
Are you reporting Accessibility issue?
None
Reproduction
https://github.com/CampbellOwen/fluentui/blob/user/owcampbe/TestIssueRepro/packages/react-components/react-button/src/components/Button/Button.test.tsx
I added a Wrapper to
Button.test.tsx
inreact-button
that doesn't render the button component and themake-styles-overrides-win
still passes.Bug Description
Actual Behavior
The
make-styles-overrides-win
conformance test inreact-conformance-griffel
directly renders the Component given and ignores therenderOptions: { wrapper: _ }
option.Expected Behavior
The call to
ReactDOM.render(element, container);
should pass the wrapper option if provided. This would allow components that require an external context to be tested.Logs
No response
Requested priority
Normal
Products/sites affected
No response
Are you willing to submit a PR to fix?
no
Validations
The text was updated successfully, but these errors were encountered: