Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Torr Pressure-Converter Option #2121

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

JacobPoteet
Copy link

Fixes #2120.

Description of the changes:

  • Implements Torr as a pressure-conversion option
  • Torr can be converted to other data types

How changes were validated:

  • Added Unit Testing

…tainability

The code changes in this commit simplify the logic in the `OnAcceleratorKeyActivated` method of `KeyboardShortcutManager.cs`.

- Replaced nested if-else statements with concise conditional expressions
- Removed redundant checks for `altPressed` and `controlKeyPressed`
- Consolidated return statements based on key combinations
…s.h.

This commit adds the Pressure_Torr constant to the list of unit constants in the UnitConverterDataConstants.h file.
This commit adds the Torr unit to the list of pressure units in the UnitConverterDataLoader.cpp file. The Torr unit is assigned a value of 7 and its localized name and abbreviation are retrieved using GetLocalizedStringName(). Additionally, the conversion data for Torr is added to the GetConversionData() function.
The code changes include adding the unit abbreviation "Torr" for pressure measurement in the Resources.resw file. This change allows users to use "Torr" as an abbreviation when working with pressure calculations.
- Add new data entry for UnitName_Torr
- Set value to "Torr"
- Set comment to "A measurement unit for Pressure."
This commit adds a new conversion data entry for "Atmospheres-Torr" in the Test.resw file. The value of this conversion is 0.00131578947368.
The commit fixes a bug in the code where the pressure units were not being added correctly. The issue was resolved by moving the `emplace` statement after adding the `pressureUnits` vector.
@JacobPoteet
Copy link
Author

@microsoft-github-policy-service agree

@JacobPoteet
Copy link
Author

@tian-lt - Apologies for the ping but would it be possible to merge this small MR?

I'm not sure if there is someone else I should request reviews from.

@tian-lt
Copy link
Contributor

tian-lt commented Feb 26, 2024

Thank you for proposing this PR, @JacobPoteet.
Let me first run the pipeline to check if it passes all the checks.

Adding @hanzhang54 @guominrui here to see if they have time to help review.

@tian-lt
Copy link
Contributor

tian-lt commented Feb 26, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Torr to Pressure Unit Conversion
2 participants