Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About LF-VILA code in PatchEmbed3D of video encoder #36

Open
musicman217 opened this issue Mar 23, 2024 · 0 comments
Open

About LF-VILA code in PatchEmbed3D of video encoder #36

musicman217 opened this issue Mar 23, 2024 · 0 comments

Comments

@musicman217
Copy link

musicman217 commented Mar 23, 2024

the padding seems not right, or maybe i made a mistake

# padding
        _, _, D, H, W = x.size() 
        if H % self.patch_size[0] != 0: 
            x = F.pad(x, (0, 0, 0, self.patch_size[1] - H % self.patch_size[1]))
        if W % self.patch_size[1] != 0:
            x = F.pad(x, (0, 0, 0, 0, 0, self.patch_size[0] - D % self.patch_size[0]))

owing to patch_size=[1, 8, 8] where 8x8 is HxW in implementation, should it be padded in H and W dimension?
condition H % self.patch_size[0] != 0 and W % self.patch_size[1] != 0 make me lost
thanks a lot!

@musicman217 musicman217 changed the title About LF-VILA code in PatchEmbed3D of vidoe encoder About LF-VILA code in PatchEmbed3D of video encoder Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant