🔎 Search Terms

non-const enum unreachable error missing

🕗 Version & Regression Information

Nightly

⏯ Playground Link

https://www.typescriptlang.org/play/?#code/GYVwdgxgLglg9mABAIwDYEMAWAKAlIgbwFgAoASHQDFwI8BuU0siBAZzlQFMA6VOAc2wAhdACduAQVwNyLMOy68B2MJwDuiSnDh5cTOQp59BIgF7cAbulQhO0xiSajOUEKLAymoSLASIqNHiETMxsHEbKIuJSMmSh8uFKgqoaWjq4euTxhknC6OZWNnaxAL4OZJxgIAC2iFGEiBKIZY6yGKysmtoNAB6IALyIAIwATADMACzN5WDo1ZysAA7oEJx1+Q2cPYtwolCIBvuFtgPD41MtJUA

💻 Code

function blah() {
	aFunc();

	console.log(Bar.A);
	console.log(new Foo())
	console.log(Baz.value);


	return;

	function aFunc() {
		console.log(Bar.A);
		console.log(new Foo())
		console.log(Baz.value);
	}

	enum Bar { A }

	class Foo { x = 1234 }

	namespace Baz { export const value = 1234 }
}

🙁 Actual behavior

No error on Bar.

🙂 Expected behavior

Error on Bar - its' definition will never run.

Additional information about the issue

This is easy to accidentally cause in our own codebase, and esbuild actually covers up the problem by hoisting/inlining the enum - the problem only shows up in an unbundled build.

checkUnreachable in binder.ts is missing a check for EnumDeclarations (and a bail from that check for const enums).