Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib/DxilPIXPasses/DxilDebugInstrumentation.cpp's addStepEntryForType should do the null check, instead of the caller #6308

Open
jeffnn opened this issue Feb 14, 2024 · 0 comments · May be fixed by #6354
Open

lib/DxilPIXPasses/DxilDebugInstrumentation.cpp's addStepEntryForType should do the null check, instead of the caller #6308

jeffnn opened this issue Feb 14, 2024 · 0 comments · May be fixed by #6354
Assignees
@jeffnn
Labels
bug Bug, regression, crash PIX Issues related to PIX passes tech-debt

Comments

@jeffnn
Copy link
Collaborator

jeffnn commented Feb 14, 2024

Description
Code issue noted in cherry-pick review:
#6300

Steps to Reproduce
No repro. Code issue.

Actual Behavior
No behavior change expected.

Environment
Not relevant.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeffnn jeffnn

Labels
bug Bug, regression, crash PIX Issues related to PIX passes tech-debt
Projects
HLSL Triage
Status: Triaged
Milestone
No milestone
2 participants
@llvm-beanz @jeffnn