Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for the addition of the DirectStorage headers (dstorage.h/dstorageerr.h). #116

Open
benvanik opened this issue Dec 20, 2023 · 2 comments

Comments

@benvanik
Copy link

It'd be great if the DirectStorage API headers were included in this repository and under the same license. Today they seem to only be available via nuget and the headers themselves aren't listed in distributable_files.txt so using them from git submodule dependencies (vs needing to use nuget) is tricky.

Specifically native/include/dstorage.h and native/include/dstorageerr.h from
https://nuget.info/packages/Microsoft.Direct3D.DirectStorage/1.2.2

@damyanp
Copy link
Member

damyanp commented Jan 2, 2024

Hi! The header files included in that package are licensed under the MIT license, as described by LICENSE-CODE.txt and the text at the beginning of those files. This was explicitly set up this way to allow you to check the headers into source control.

The distributable_files.txt refers to the executable, binary code, that are covered by LICENSE.txt.

@benvanik
Copy link
Author

benvanik commented Jan 2, 2024

Oh, neat! I hadn't noticed LICENSE-CODE.txt as covering those. Would still be cool to have them here so there's a one-stop submodule for users but this at least makes it easier to have our own submodule containing them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants