Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crash on cmLocale.h #23

Open
dvirtz opened this issue Mar 9, 2017 · 0 comments
Open

crash on cmLocale.h #23

dvirtz opened this issue Mar 9, 2017 · 0 comments

Comments

@dvirtz
Copy link

dvirtz commented Mar 9, 2017

I'm trying to use Hunter package manager with Microsoft's CMake and get a crash when CMake tries to unpack hunter.
I've tracked down the crash to the destructor at cmLocale.h, which is caused because setlocale overrides OldLocale's contents.

I've noticed that upstream CMake already has a fix for this crash, so I'll open a PR with this fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dvirtz