-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chores and code hygiene #4968
Labels
feature-request
Azure report label
Comments
OEvgeny
added a commit
to OEvgeny/BotFramework-WebChat
that referenced
this issue
Dec 20, 2023
Address the first 3 suggestions from microsoft#4968 As we remove `FC/VFC` I thought it'd be nice to add `ReactNode` return type basically to: - Serve as an additional hint that the function follows React Component signature - Limit usage of unsupported by React runtime return types
This was referenced Dec 20, 2023
OEvgeny
added a commit
that referenced
this issue
Jan 10, 2024
Address the first 3 suggestions from #4968 As we remove `FC/VFC` I thought it'd be nice to add `ReactNode` return type basically to: - Serve as an additional hint that the function follows React Component signature - Limit usage of unsupported by React runtime return types
OEvgeny
added a commit
that referenced
this issue
Jan 19, 2024
Address the first 3 suggestions from #4968 As we remove `FC/VFC` I thought it'd be nice to add `ReactNode` return type basically to: - Serve as an additional hint that the function follows React Component signature - Limit usage of unsupported by React runtime return types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem?
We need to update Web Chat to clear up some chores and code hygiene. This is a non-exhaustive list.
Describe the suggestion or request in detail
FC
/VFC
types, useProps
instead Address XS code hygiene tasks #4981import { type ABC }
overimport type { ABC }
Address XS code hygiene tasks #4981use-ref-from
anduse-state-with-ref
, fromuseValueRef
string
toActivityKey
of typewc.a.${string}
isFromUser
,hasSent
) to core packageWebChatActivity
and many things as read-onlybotframework-webchat-base
(Add base package #5176)base
package will be bundled and not publishedtsup
(Emit ESM build via tsup #5148)react-chain-of-responsibility
(Feature/middleware v2 init #5118)lerna@6
tolerna@7
or pure NPM workspaces #4847useStyleOptions
inside activity middleware could read partial style options from channel datacreate-react-app
, Webpack 4/5, esbuildvalibot
to validate props from external #5182micromark
or other synchronousmdast
packages, need table extension, strikethrough extension, and auto-link #4844dompurify
Activity[]
instead ofactivity$
Notes: Mutex = when this work is started, will block all other works
Describe alternatives you have considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: