-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It is always "Retrieving configuration..." when adding one custom environment if using 'https://maneg.com' as the ARM endpoint #7899
Comments
@v-kellyluo This does not reproduce for me at all using the same build or on our main branch. Clicking Add does require network communication. Perhaps there was a network issue? Does this still reproduce for you? |
Hi @craxal, we waited more than 10 minutes, this issue still reproduces on our side, and it doesn't reproduce in 1.30.2 on the same machine. |
@v-kellyluo I still don't reproduce. Can you provide app logs? Test machine? |
@craxal , here is the logs, and I will share the test machine in Teams. |
There's a "TypeError: Converting circular structure to JSON" error getting thrown that isn't being caught. Here's what I think is happening:
This is...a problem. I don't think we ever anticipated any error or error-like objects to contain circular references. We'll need to handle this somehow at some point. To clarify, though, I do not believe this is a regression, as the circular references issue has always been there; it's just surfacing now, for some reason. Also, considering this only happens when the management endpoint doesn't exist, and we don't accept them until we've gotten positive confirmation that it does, I don't think a fix for this is urgent. |
Storage Explorer Version: 1.34.0-dev (98)
Build Number: 20240425.1
Branch: main
Platform/OS: Windows 10/Linux Ubuntu 22.04/MacOS Sonoma 14.4.1(Apple M1 Pro)
Architecture: x64/x64/arm64
How Found: Ad-hoc testing
Regression From: Previous release (1.30.2)
Steps to Reproduce
Expected Experience
An error message appears.
Actual Experience
It is always in a verified state.
The text was updated successfully, but these errors were encountered: