Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filepaths with dots in them do not match with brace ranges #212

Open
starpit opened this issue Mar 10, 2021 · 6 comments
Open

filepaths with dots in them do not match with brace ranges #212

starpit opened this issue Mar 10, 2021 · 6 comments
Labels

Comments

@starpit
Copy link

starpit commented Mar 10, 2021

(Thanks for reporting an issue to micromatch! If you haven't already read the contributor guidelines, Please do that now, then proceed to fill out the details below.)

Please describe the minimum necessary steps to reproduce this issue:

npm init -y
npm install [email protected] 
node
> require('micromatch').isMatch('a.b', 'a.b')
true
> require('micromatch').isMatch('a.000', 'a.000')
true
> require('micromatch').isMatch('a.000', 'a.00{0,1}')
true
> require('micromatch').isMatch('a.000', 'a.00{0..1}')
false /* <---- should be true? */
> require('micromatch').isMatch('a000', 'a00{0..1}')
true

What is happening that shouldn't be?

When a filepath contains a dot, brace range expansion does not seem to work as expected. But brace enumeration expansion seems fine.

What should be happening instead?

It shouldn't matter if the filepath has a dot?

@starpit
Copy link
Author

starpit commented May 15, 2021

Is this project being maintained? I see a PR that perhaps addresses this... from two years ago?

ref: #170

@jonschlinkert
Copy link
Member

It might not be an urgent issue. Read this: https://github.com/jonschlinkert/idiomatic-contributing/#dont

@starpit
Copy link
Author

starpit commented May 15, 2021

Thanks for the response! I wasn't sure, given the staleness of both.

@jonschlinkert
Copy link
Member

I currently have close to 1,000 issues on all of the repos I maintain. I've resolved tens of thousands of issues. We implement automated responses or bots on some big projects, but those systems also need to be maintained.

I will look into this next time I work on this library.

@starpit
Copy link
Author

starpit commented May 15, 2021

No worries, I completely understand. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants
@jonschlinkert @starpit and others