Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Download option disappears when viewing search results #667

Open
Ewokosaur opened this issue Feb 9, 2024 · 2 comments
Open

[bug] Download option disappears when viewing search results #667

Ewokosaur opened this issue Feb 9, 2024 · 2 comments

Comments

@Ewokosaur
Copy link

Description of the bug

The download option which normally appears when selecting checkboxes of files and folders disappears when using the search function.

I am self-hosting FileStash using docker behind an nginx reverse proxy.

Filestash is connected to an S3 bucket and displays all files and folders normally.

 

Step by step instructions to reproduce the bug:

Input any search matching a file or folder name and view the results.

Can you replicate that error from the demo?

Yes, this behavior is present in the demo as well.

Observed behavior

Download option does not appear, but I am still able to select multiple files/folders using the checkboxes.

Expected behavior

Due to the level of functionality observed when not searching, I believe that a download option should be present for the results of a search, allowing users to locate items and download them using multiselect.

If this is not intended functionality, no worries :)

While viewing search results:
with_search

While viewing files normally:
without_search

@Ewokosaur Ewokosaur changed the title [bug] Download option disappears from search results. [bug] Download option disappears when viewing search results Feb 9, 2024
@Ewokosaur
Copy link
Author

Looking at the site through dev tools, it seems to be something related to the div class "menubar no-select search_focus" which does not allow the download button to appear, despite showing up as a span once I have selected something while searching.

If I change the class back to "menubar no-select" after having selected the folders/files I searched up I am then able to view the download button.

search_focus
no_search_focus

@Ewokosaur
Copy link
Author

I was able to temporarily work around this using the following CSS:

.button-download {
display: inline-block !important;
visibility: visible !important;
opacity: 1 !important;
}

Using this temporary fix, I am now able to select and download files from search results, but I want to leave this up so it can be addressed permanently in a future patch.

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant