-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not preserving low level signature metadada #148
Comments
Decorator 5 (notice the change in the major version number) changed its implementation to not use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
(Sorry if the title is somewhat misleading or I did get some jargon wrong)
In version 5.1.1 methods decorated by decorate created with the decorator lib stopped working with qt(pyqt?) signals that inspect the signature of the connected slot (also tested with 4.0.2 with a slight different error).
Failing snippet:
This was not an issue in 4.4.2.
While porting our code base to python 3.10 the decorator version also got upgraded, decorator version prior to this was 4.4.2.
We will probably be able to downgrade back for now.
I created a test to reproduce the error.
add_qt_test_patch.txt
Create env and install decorator in editable mode:
Test with 4.4.2 (pass):
Test with 5.1.1 (fail, at the time of this writing
origin/master
will also fail):I also was somewhat curious.
"Plain" functions:
Decorated with 4.4.2:
Decorated with 5.1.1:
The text was updated successfully, but these errors were encountered: