Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fresh repository clone yarn test fails #151

Open
kresli opened this issue Nov 13, 2019 · 3 comments
Open

fresh repository clone yarn test fails #151

kresli opened this issue Nov 13, 2019 · 3 comments
Labels
bug Something isn't working

Comments

@kresli
Copy link

kresli commented Nov 13, 2019

  • git clone
  • nvm install
  • yarn
  • yarn test

image

@kresli
Copy link
Author

kresli commented Nov 13, 2019

ok so fixed failing test by running yarn build. Then I end up with

Screen Shot 2019-11-13 at 8 15 08 PM

@michalochman michalochman added the bug Something isn't working label Nov 14, 2019
@michalochman
Copy link
Owner

Hi @kresli, yes, the tests for react-pixi-alias require that the app is built first. I'll update the README.

With regards to the warning, I was not able to get rid of it in tests, I was not experiencing it when launching the app, possibly some React or shallow renderer version mismatch

@kresli
Copy link
Author

kresli commented Nov 14, 2019

Thanks for quick respond. I would guess is all test are executed concurrency which using same Context. Eg:

render(
      <AppContext.Provider value={app}>
       ...
      </AppContext.Provider>,
      app.stage
    );

If you create new AppContext for each test, the warning should go away. I didn't test it, just guessing here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants