Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keypoints out off the crop #128

Open
rafikg opened this issue Oct 21, 2019 · 2 comments
Open

keypoints out off the crop #128

rafikg opened this issue Oct 21, 2019 · 2 comments

Comments

@rafikg
Copy link

rafikg commented Oct 21, 2019

Hi @michalfaber

coords[:, 0] -= left_up[0]
coords[:, 1] -= left_up[1]
return coords

Here I think that you have to check if the keypoints are inside or outside the crop. I see that you checked the negative coordinates inside the point8_to_joints() functions but for the positive values that greater than (368, 368), I don't see any filter!

@michalfaber
Copy link
Owner

Hi @deeperdeeper
Thanks for the comment. There is no filtering in CropAug because its only purpose is to transform images and coordinates. I agree that there should be more strict filtering in point8_to_joints but the current implementation still gives the correct results. If a joint is outside of the area it will not be used to put a gaussian peak in the heatmap.

@rafikg
Copy link
Author

rafikg commented Oct 23, 2019

Thanks, @michalfaber, It is what I expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants