-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get_signatures_for_address is missing min_context_slot param #425
Comments
Its simple enough that I can do a PR. Can I be granted the relevant permissions @michaelhly please? |
@don1989 Yes. Just add the solana-py/src/solana/rpc/api.py Line 312 in ff9af68
solana-py/src/solana/rpc/async_api.py Line 324 in ff9af68
solana-py/src/solana/rpc/core.py Line 214 in ff9af68
and then fix any relevant tests, lint and formatting issues. Please fork this repo and contribute a pull request pointing to michaelhly/solana-py. |
Hello
The
min_context_slot
param is missing in theget_signatures_for_address
method. I noticed that it is present in the config object that we send in the request:However, I don't understand why
min_context_slot
is missing in get_signatures_for_address and why we're not passing it to the config:Is it possible to add it in the next release?
For reference: https://solana.com/docs/rpc/http/getsignaturesforaddress
Thanks
The text was updated successfully, but these errors were encountered: