Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update marshmallow to 2.18.1 #165

Open
ivan-artezio opened this issue Jun 27, 2019 · 4 comments
Open

Update marshmallow to 2.18.1 #165

ivan-artezio opened this issue Jun 27, 2019 · 4 comments

Comments

@ivan-artezio
Copy link

Marshmallow 2.18.0 raises ChangedInMarshmallow3Warning for nested schemas which is annoying when running tests and clogs the logs. Marshmallow should be updated to 2.18.1 where this issue was fixed.
https://marshmallow.readthedocs.io/en/3.0/changelog.html
marshmallow-code/marshmallow#1136

@multimeric
Copy link
Contributor

I would say Marshmallow needs to be updated to 3.X

@PATolk
Copy link

PATolk commented Nov 1, 2019

I needed to upgrade Marshmallow to 3.2.1
and now I get an error
File "/lib/python3.6/site-packages/flask_rest_jsonapi/resource.py", line 131, in get
result = schema.dump(objects).data
AttributeError: 'dict' object has no attribute 'data'

@multimeric
Copy link
Contributor

Yes, the library has to be changed to make it Marshmallow 3 compatible. I've fixed this in my PR: #172. However it hasn't yet been merged.

@auvipy
Copy link

auvipy commented Sep 2, 2021

this can be closed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants