Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link closing tag is forbidden #90

Open
agenestar opened this issue Sep 30, 2019 · 1 comment
Open

Link closing tag is forbidden #90

agenestar opened this issue Sep 30, 2019 · 1 comment
Labels
bug

Comments

@agenestar
Copy link

Rel links generated by the library contain a frobidden closing tag as mentioned in the w3 documentation.

scrivener_html/lib/scrivener/html/seo.ex

Line 89 in ec9283a

content_tag(:link, [], href: href, rel: rel(paginator, paginator.page_number + 1))

Would it be possible to use tag(:link instead of content_tag(:link?
@mgwidmann
Copy link
Owner

Please submit a PR and I would be willing to merge it.

@mgwidmann mgwidmann added the bug label Dec 17, 2019
@agenestar agenestar mentioned this issue Feb 18, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mgwidmann @agenestar