-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SEO header links not taking non-existing pages into account #69
Comments
Sorry I missed this. If you'd like to submit a PR, I'd be willing to merge and release it if is a bug like you describe. Thanks for reporting! |
I'll see to find some time to do the PR! |
Should we close this or do you still think this is a valuable addition? |
This was referenced Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Thanks for the library and the whole scrivener libraries!
I have an issue with the header links generated by scrivener_html. If I am reading the code correctly there is currently no checking if the next/prev page does indeed exist?
In my opinion, checking if the next/prev pages exist (by looking the the
total_pages
in relation to thepage_number
) and skipping prev/next should do the trick. This would also mean the special cases for the first and last page at https://github.com/mgwidmann/scrivener_html/blob/master/lib/scrivener/html/seo.ex#L42 could be removed as they would be covered.If you are ok with a PR regarding this I can look into it!
The text was updated successfully, but these errors were encountered: